Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue with resurrection of tombstones #4180

Merged
merged 2 commits into from
Dec 10, 2020
Merged

Fix issue with resurrection of tombstones #4180

merged 2 commits into from
Dec 10, 2020

Conversation

jedelbo
Copy link
Contributor

@jedelbo jedelbo commented Dec 8, 2020 •
edited
Loading

@jedelbo jedelbo requested a review from ironage December 8, 2020 08:31
ironage
ironage approved these changes Dec 9, 2020
View reviewed changes
Copy link
Contributor

@ironage ironage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't appear to be the fix unfortunately, but this change still has value as an optimization.

@jedelbo jedelbo changed the title Workaround potential bug in Cluster::try_get Fix issue with resurrection of tombstones Dec 9, 2020
ironage
ironage approved these changes Dec 9, 2020
View reviewed changes
Copy link
Contributor

@ironage ironage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really great work tracking this one down! Even seeing the fix and the test, it still took me a while to understand what was going on here.

@bmunkholm
Copy link
Contributor

@ironage What would it take to make it easier to comprehend? Comments?

@jedelbo
Copy link
Contributor Author

jedelbo commented Dec 10, 2020

@bmunkholm I added some comments in the test. It will be hard to get your head around anyway.

@jedelbo
Fix bug in tombstone resurrection
32eb2cc 
While iterating through a tombstones backlink columns it may be erased
underneath if the last backlink was removed. In this case the iteration
must be aborted.
@jedelbo jedelbo merged commit 30e5474 into v10 Dec 10, 2020
@jedelbo jedelbo deleted the je/cluster-try-get branch December 10, 2020 08:42
@kneth kneth mentioned this pull request Dec 11, 2020
Merged
1 task
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ironage ironage ironage approved these changes

@finnschiermer finnschiermer Awaiting requested review from finnschiermer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jedelbo @bmunkholm @ironage @finnschiermer