Backup and Restore #4166

finnschiermer · 2020-12-04T12:51:09Z

Backup and restore

Automatically create a backup before file format upgrades. Retain backups for 3 months.
Automatically restore if rolling back to before a file format upgrade for wich a backup is present.

☑️ ToDos

📝 Changelog update
🚦 Tests (or not relevant)
🚦 Check for sufficient file space first
🚦 Report problems in a log file

…-restore

src/realm/backup_restore.cpp

src/realm/db.cpp

src/realm/db_options.hpp

src/realm/backup_restore.cpp

test/test_upgrade_database.cpp

jedelbo · 2021-02-05T14:54:41Z

@finnschiermer you can add me as reviewer when this is ready again.

…restore

src/realm/backup_restore.cpp

test/object-store/CMakeLists.txt

…restore

sipersso · 2023-04-18T09:58:47Z

What problem does this solve? Is it possible to catch/disable this behavior for local realms?

If I understand this correctly.

1: The user upgrades to a new version of the app that contains a realm file format upgrade.
2: The user adds data to the new database.
3: I release a new version that reverts the database version and the file format.
4: The user upgrades.

I assume that if this happens all data that the user added in step 2 will be lost?

finnschiermer added 3 commits December 1, 2020 15:54

prototype backup/restore machinery

2cf03f0

added backup to options, some cleanup in DB::do_open

2de4e50

first test of backup/restore and mockup logic in support

0f33ed1

finnschiermer added the T-Enhancement label Dec 4, 2020

finnschiermer self-assigned this Dec 4, 2020

finnschiermer and others added 4 commits December 4, 2020 14:04

one more test of backup/restore

bf40a1f

clang-format

4d3d05d

better clang-format

cbac926

Merge branch 'develop' of github.com:realm/realm-core into fsa/backup…

21b8aff

…-restore

finnschiermer force-pushed the fsa/backup-restore branch from a899087 to 1a6a854 Compare December 8, 2020 13:33

clang format (III)

fa85953

finnschiermer force-pushed the fsa/backup-restore branch from 1a6a854 to fa85953 Compare December 8, 2020 13:37

added timeout to deletion list

1aa4e84

finnschiermer force-pushed the fsa/backup-restore branch from d34a622 to 1aa4e84 Compare December 8, 2020 14:52

finnschiermer and others added 5 commits December 9, 2020 16:46

take age of backup files into account

60b206a

handle backup failure, update changelog

9e510a9

clang-format IV

e4058fc

remove include of <filesystem>

f8343a5

don't use sleep on Windows

ea71967

finnschiermer force-pushed the fsa/backup-restore branch 3 times, most recently from b3bd421 to b292188 Compare December 10, 2020 16:10

tentative windows impl of last_write_time()

6123c81

finnschiermer force-pushed the fsa/backup-restore branch from b292188 to 6123c81 Compare December 10, 2020 16:30

finnschiermer and others added 3 commits December 15, 2020 16:49

refactored backup logic into a class

180fefd

clang-format V

f617f58

fix warning

b554ee0

finnschiermer requested a review from jedelbo December 15, 2020 17:29

finnschiermer changed the title ~~WIP Backup and Restore~~ Backup and Restore Dec 16, 2020

jedelbo requested changes Dec 17, 2020

View reviewed changes

jedelbo requested a review from RedBeard0531 January 18, 2021 14:04

Base automatically changed from develop to breaking February 1, 2021 14:35

jedelbo removed their request for review February 5, 2021 14:54

finnschiermer changed the base branch from breaking to master February 8, 2021 13:53

Merge branch 'master' of github.com:realm/realm-core into fsa/backup-…

8fd7696

…restore

fealebenpae reviewed Feb 8, 2021

View reviewed changes

src/realm/backup_restore.cpp Show resolved Hide resolved

finnschiermer added 2 commits February 15, 2021 15:13

expose backup control flag through Realm::Config

e5445fb

add object store test for control of backup

fa27865

jedelbo approved these changes Mar 11, 2021

View reviewed changes

test/object-store/CMakeLists.txt Show resolved Hide resolved

finnschiermer added 2 commits March 11, 2021 10:59

make 'fake_target_file_format' local to Group

dae077f

Merge branch 'master' of github.com:realm/realm-core into fsa/backup-…

b0e2211

…restore

finnschiermer force-pushed the fsa/backup-restore branch from ab9d5d9 to b0e2211 Compare March 11, 2021 10:18

finnschiermer added 7 commits March 15, 2021 14:44

moved backup tests out of swift package manager flow

ebaf601

extend lifetime of backup in unittest to cater for slow CI

6dc2fe4

marking upgrade tests nonconcurrent

923b681

Merge branch 'master' of github.com:realm/realm-core into fsa/backup-…

3e6f0b5

…restore

adjust test to allow for time deviation

349706a

don't use _stat() to get file modif time on Windows - it's defunct

fb069f4

undo earlier change to testcase

15da9f6

finnschiermer force-pushed the fsa/backup-restore branch from 86a9f4f to 15da9f6 Compare March 29, 2021 08:08

use CreateFile2, not just CreateFile

7310edf

finnschiermer requested a review from jedelbo March 29, 2021 11:15

Merge branch 'master' of github.com:realm/realm-core into fsa/backup-…

7270531

…restore

jedelbo approved these changes Mar 29, 2021

View reviewed changes

finnschiermer merged commit aa4609c into master Mar 29, 2021

finnschiermer deleted the fsa/backup-restore branch March 29, 2021 12:14

kneth mentioned this pull request Jul 15, 2021

iOS "Unsupported Realm file format version" realm/realm-js#3303

Closed

github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Backup and Restore #4166

Backup and Restore #4166

finnschiermer commented Dec 4, 2020 •

edited

Loading

jedelbo commented Feb 5, 2021

sipersso commented Apr 18, 2023

Backup and Restore #4166

Backup and Restore #4166

Conversation

finnschiermer commented Dec 4, 2020 • edited Loading