Correctly update case insensitive queries on indexed string columns #3962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
finnschiermer
approved these changes
Oct 2, 2020
bmunkholm
reviewed
Oct 2, 2020
| @@ -5,7 +5,7 @@ | |||
|
|
|||
| ### Fixed | |||
| * <How to hit and notice issue? what was the impact?> ([#????](https://github.com/realm/realm-core/issues/????), since v?.?.?) | |||
| * None. | |||
| * If you make a case insignificant query on an indexed string column, it may fail in a way that results in a "No such key" exception. ([#6830](https://github.com/realm/realm-cocoa/issues/6830), since v6.0.0) | |||
There was a problem hiding this comment.
insignificant -> insensitive? @jedelbo
There was a problem hiding this comment.
Can we better describe under which conditions could it fail?
|
Confirmed that it's fixed with a forked repo with the updated core. Thanks! (and surprising to me that it seems nobody else uses case insensitive search?!) |
|
There's another (much less frequent) crash that seems related to case insensitive search on indexed properties - could you help take a look @jedelbo ? realm/realm-swift#6836 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIxes realm/realm-swift#6830