Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix for #3352 #3357

Merged
merged 3 commits into from
Aug 23, 2019
Merged

fix for #3352 #3357

merged 3 commits into from
Aug 23, 2019

Conversation

finnschiermer
Copy link
Contributor

@finnschiermer finnschiermer commented Aug 20, 2019 •
edited
Loading

Fixes #3352

@finnschiermer finnschiermer requested a review from jedelbo August 20, 2019 15:37
@realm-probot
Copy link

realm-probot bot commented Aug 20, 2019

Hey - looks like you forgot to add a T:* label - could you please add one?

@BlueCobold
Copy link

Won't it maybe be a good idea to limit the number of retries?

@bmunkholm
Copy link
Contributor

I would also suggest to set a limit to retires, and perhaps sleep. If all retries fails, throw exception.

jedelbo
jedelbo requested changes Aug 21, 2019
View reviewed changes
Copy link
Contributor

@jedelbo jedelbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit message should be changed.

@finnschiermer
Copy link
Contributor Author

@jedelbo I'll change it when I squash & commit

@finnschiermer finnschiermer merged commit 4add2e7 into master Aug 23, 2019
@finnschiermer finnschiermer deleted the fsa/make-msync-restart-on-eintr branch August 23, 2019 14:17
@finnschiermer finnschiermer mentioned this pull request Feb 18, 2020
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jedelbo jedelbo jedelbo approved these changes

Assignees
No one assigned
Labels
T-Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

msync() failed: Interrupted system call in ... io_realm_internal_OsSharedRealm.cpp line 101
5 participants
@finnschiermer @BlueCobold @bmunkholm @jedelbo @realm-ci