-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize timestamp queries: ==, !=, !NULL #3351
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was able to squeeze it a bit more. A simple optimization in
|
jedelbo
force-pushed
the
js/timestamp-query-equality
branch
from
August 16, 2019 08:50
20b8ee8
to
ed9e86a
Compare
jedelbo
force-pushed
the
js/timestamp-query-equality
branch
from
August 16, 2019 11:15
f1222a5
to
c289987
Compare
jedelbo
approved these changes
Aug 16, 2019
finnschiermer
approved these changes
Aug 16, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add TimestampNode specializations for: Equal, NotEqual, NotNull.
Here's the timestamp benchmarks for the naïve generic search:
And here's the timestamp benchmarks for this branch: