Add a Swift Package Manager package #3308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. |
ironage
approved these changes
Jun 26, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required for Cocoa to support SPM, as it only supports purely building from source with only SPM-based dependencies.
SPM doesn't have any concept of a "configure" step, so I pushed the part of version.hpp that cmake modifies into a separate header that isn't included when building with SPM and instead hardcoded the version number in package.swift. It can't simply read the version from dependencies.list because the package is evaluated in a sandbox with no access to any other files in the repository. The release script takes care of updating this additional copy of the version, so this shouldn't be a problem.