-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use index on int equal queries #3272
Conversation
9002f5c
to
08e7795
Compare
08e7795
to
4310b4a
Compare
Here's the benchmark results of this PR compared to core v5.18.0 using a column of 1 million unique integers.
This shows a nice improvement across the board. The largest improvement in practice will be for users who chain many "OR" conditions together or heavily query an int primary key column (indexed automatically). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
Any idea why the index makes such little difference at 1000 conditions? Is
there some other overhead that dominates in that case?
On Mon, 1 Apr 2019 at 23.02, James Stone ***@***.***> wrote:
Merged #3272 <#3272> into master.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#3272 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAEPLvDFDswvXYZInjzh2j0U06Yfx-Ryks5vcnPXgaJpZM4cWFvr>
.
--
*Alexander Stigsen, CTO*
Realm Inc
|
If you have a 1000 conditions on a column with index, the query engine must visit 1000 nodes that each must lookup a value. |
No description provided.