Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the S3 operations #2888

Merged
merged 2 commits into from
Oct 25, 2017
Merged

Improve the S3 operations #2888

merged 2 commits into from
Oct 25, 2017

Conversation

emanuelez
Copy link
Contributor

This PR allows to:

  • fail builds if the S3 operation fails. Before the error code was swallowed by find
  • remove the dependency on s3cmd

@codecov-io
Copy link

Codecov Report

Merging #2888 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2888      +/-   ##
==========================================
+ Coverage   92.61%   92.61%   +<.01%     
==========================================
  Files         245      245              
  Lines       75783    75782       -1     
  Branches     4345     4344       -1     
==========================================
+ Hits        70187    70189       +2     
  Misses       5250     5250              
+ Partials      346      343       -3
Impacted Files Coverage Δ
test/test_thread.cpp 81.28% <0%> (-0.04%) ⬇️
test/main.cpp
test/benchmark-history-types/main.cpp 100% <0%> (ø)
test/test_shared.cpp 88.94% <0%> (+0.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3668857...9eea44f. Read the comment docs.

@emanuelez
Copy link
Contributor Author

@alebsack ping :)

@realm realm deleted a comment from realm-ci Oct 9, 2017
@realm realm deleted a comment from realm-ci Oct 9, 2017
@finnschiermer
Copy link
Contributor

@emanuelez @alebsack What's the future of this PR - it's been hanging around for a couple of weeks now?

@emanuelez emanuelez merged commit dc4f9e9 into master Oct 25, 2017
@emanuelez emanuelez deleted the ez/fix-s3-operations branch October 25, 2017 09:08
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants