Fixed column removal related bugs exposed by test.py (python binding) #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -378,10 +387,24 @@ size_t Spec::get_column_index(StringData name) const | |||
| return m_names.find_first(name); | |||
| } | |||
|
|
|||
| size_t Spec::get_column_pos(size_t column_ndx) const { | |||
There was a problem hiding this comment.
Funny placement of brace
added 2 commits
November 10, 2013 11:48
|
👍 |
astigsen
pushed a commit
that referenced
this pull request
Nov 10, 2013
Fixed column removal related bugs exposed by test.py (python binding)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing test.py in python binding exposed som serious bugs when removing columns. It has been fixed and unit tests have been expanded to catch the issues.