Missing pthread_mutex_consistent() #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
pthread_mutex_consistent was added to glibc ver 2.12 - I'll add a check based on glibc version defines. |
added 3 commits
September 5, 2013 17:03
… mutex_problem Conflicts: src/tightdb/thread.cpp
| @@ -2,17 +2,31 @@ | |||
|
|
|||
| #include <tightdb/exceptions.hpp> | |||
| #include <tightdb/thread.hpp> | |||
| #include <features.h> | |||
There was a problem hiding this comment.
As far as I know, <features.h> is not a standard header, nor is it required by POSIX. Consider Windows and Mac. On Linux, it will be included via <unistd.h>, which is already included below, so no explicit include seems to be required.
We must strive for a minimum level of portability where we require only that the platform is either POSIX or Windows. Of course, an even higher level of portability is welcome if it can be provided. Note that <unistd.h> is required by POSIX.
|
👍 (except for the problematic include) |
|
I don't know if you know it already, but after you can do |
finnschiermer
pushed a commit
that referenced
this pull request
Sep 9, 2013
…istent Handle missing pthread_mutex_consistent() in glibc versions prior to 2.12
tgoyne
pushed a commit
that referenced
this pull request
Jul 11, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the added FIXME for details.
@finnschiermer