-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed errors in documentation update. #120
Conversation
@@ -881,7 +881,7 @@ CATEGORIES : | |||
the returned index is then unspecified, it is still | |||
guaranteed to be within the usual range. | |||
- NAME : value | |||
TYPES : [ std::int64_t, bool, float, double, StringData ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you remove the 'std::' prefix here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is consistent with all other CPP documentation currently. And the system
can't handle it. I guess we only have to put it in "" to work.
But still for consistency.
// Brian
On Sun, Aug 4, 2013 at 3:39 PM, Kristian Spangsege <[email protected]
wrote:
In doc/ref_cpp/data/dyn_table_ref.yaml:
@@ -881,7 +881,7 @@ CATEGORIES :
the returned index is then unspecified, it is still
guaranteed to be within the usual range.
- NAME : value
TYPES : [ std::int64_t, bool, float, double, StringData ]
Why did you remove the 'std::' prefix here?
—
Reply to this email directly or view it on GitHubhttps://github.com//pull/120/files#r5569558
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But the system handles std::size_t, right? How does it do that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As of now the TYPES are not used for anything when you write the PROTOTYPE yourself.
Fixed errors in documentation update.
Please run documentation generation before pushing to master.
@kspangsege