Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed errors in documentation update. #120

Merged
merged 1 commit into from
Aug 12, 2013
Merged

Fixed errors in documentation update. #120

merged 1 commit into from
Aug 12, 2013

Conversation

bmunkholm
Copy link
Contributor

Please run documentation generation before pushing to master.
@kspangsege

@ghost ghost assigned kspangsege Aug 4, 2013
@@ -881,7 +881,7 @@ CATEGORIES :
the returned index is then unspecified, it is still
guaranteed to be within the usual range.
- NAME : value
TYPES : [ std::int64_t, bool, float, double, StringData ]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you remove the 'std::' prefix here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is consistent with all other CPP documentation currently. And the system
can't handle it. I guess we only have to put it in "" to work.
But still for consistency.

// Brian

On Sun, Aug 4, 2013 at 3:39 PM, Kristian Spangsege <[email protected]

wrote:

In doc/ref_cpp/data/dyn_table_ref.yaml:

@@ -881,7 +881,7 @@ CATEGORIES :
the returned index is then unspecified, it is still
guaranteed to be within the usual range.
- NAME : value

  •    TYPES  : [ std::int64_t, bool, float, double, StringData ]
    

Why did you remove the 'std::' prefix here?


Reply to this email directly or view it on GitHubhttps://github.com//pull/120/files#r5569558
.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But the system handles std::size_t, right? How does it do that?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As of now the TYPES are not used for anything when you write the PROTOTYPE yourself.

bmunkholm pushed a commit that referenced this pull request Aug 12, 2013
Fixed errors in documentation update.
@bmunkholm bmunkholm merged commit ec85731 into realm:master Aug 12, 2013
tgoyne pushed a commit that referenced this pull request Jul 11, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants