Set subtable #116
Merged
Set subtable #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…et_subtable from langbindhelper. output to cerr excepion text in test_transactions.cpp (if an exception was thrown). updated dyn_table_ref.yaml (not sure if this is the right way to do it) with an extra line below the lines with set_* method headers.
|
+1 |
| @@ -587,6 +587,7 @@ CATEGORIES : | |||
| void set_string(size_t column_ndx, size_t row_ndx, StringData value); | |||
| void set_binary(size_t column_ndx, size_t row_ndx, BinaryData value); | |||
| void set_mixed(size_t column_ndx, size_t row_ndx, Mixed value); | |||
| void set_subtable(siz_t column_ndx, size_t row_ndx, const Table*); | |||
There was a problem hiding this comment.
You also need to add two lines:
- g_dyn_table_set_subtable:
NAME : set_subtable
just below the line: "NAME: set_mixed"
|
Shouldn't TableView have it as well? |
|
You also need to add a line in doc/changes.txt whenever a new feature is implemented. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
\cc @kspangsege
added cerr of exception text in test_transactions unit test.
made set_subtable public in table
removed set_subtable from langbindhelper