Replication

[rrrlasse]

In encode_int():

TIGHTDB_STATIC_ASSERT(std::numeric_limits<T>::is_integer, "Integer required");

If insertion can fail in replication, then insertion must fail in "core" insertion too, because behaviour in "core" and replication should be completely identical.

[kspangsege]

The static assert that you mention is just a compile time sanity check. With the current state of the code, the assert is not triggered, so all should be fine. Note that this assert cannot trigger at run time. It is there to help catch errors when the code is modified in the future.

I agree that replication mode must work identically to normal mode if at all possible.
If not possible, the differences should be few, well understood, and well documented.