Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update SourceKitten to 0.15.1 #690

Closed
wants to merge 1 commit into from
Closed

update SourceKitten to 0.15.1 #690

wants to merge 1 commit into from

Conversation

jpsim
Copy link
Collaborator

@jpsim jpsim commented Nov 29, 2016

No description provided.

@jpsim
Copy link
Collaborator Author

jpsim commented Nov 29, 2016

I've unfortunately uncovered a regression with this version of SourceKitten causing Objective-C enums to not be properly documented.

@jpsim
Copy link
Collaborator Author

jpsim commented Nov 29, 2016

I filed an issue towards SourceKitten to track fixing that regression: jpsim/SourceKitten#304

I won't be merging this PR due to this regression, but will open a new one once the issue is resolved and another version of SourceKitten is available.

@jpsim jpsim closed this Nov 29, 2016
@jpsim jpsim deleted the jp-sourcekitten-0.15.1 branch November 29, 2016 23:30
@DangerCI
Copy link

DangerCI commented Dec 1, 2016 

        1 Error
    
  </th>
 </tr>
🚫

Please include a CHANGELOG entry. You can find it at CHANGELOG.md.

 
        1 Warning
    
  </th>
 </tr>
⚠️ This PR may need tests. 
        1 Message
    
  </th>
 </tr>
📖 Note, we hard-wrap at 80 chars and use 2 spaces after the last line.

Generated by 🚫 danger

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jpsim jpsim

Labels
github-review-rejected
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jpsim @DangerCI @istx25