-
Notifications
You must be signed in to change notification settings - Fork 414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrated markdown parsing and guide support #523
Conversation
I think I also need to separate this into smaller testable chunks to be submitted separately as PR's. |
Integration specs are failing with the following stack trace:
|
Yeah 😳. I missed a couple of things in the process of rebasing. This PR could do with a WIP label. I mainly wanted to show some progress to guilt myself into getting it finished. |
No guilt needed! Let me know if/how I can help. |
Woot. I'm finally rebased AND passing tests. |
end | ||
|
||
def self.documentation_entries | ||
return [] unless |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think it would make sense to filter files named index.*
here too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I probably wouldn't hurt, but I'm not sure if it's necessary there. Without it, it makes it possible to override the readme and have it included in the Dash Guides section.
It'd be good to add a basic test for this in the misc_jazzy_features fixture Also, some basic documentation describing how to use this in jazzy's readme would be nice. |
Good catch. Will do. 👍 |
Hi, |
@JanC still waiting on:
|
Hey @jpsim, my first attempt at fixtures and Readme are in. The fixture tests are passing, but they are pointed at my fork until they are ok to merge in (realm/jazzy-integration-specs#18). Once they are the fixtures are right to merge, I'll point the submodule back to realm and we can merge this. |
This is super great! Love the feature, love the docs you added 😄 I've merged realm/jazzy-integration-specs#18 and given you commit access to jazzy repos to simplify this in the future. I think the only thing this is missing now is a changelog entry. Could you make a new PR for that? I'll merge this one right away. |
This was merged but not yet released, correct? |
Correct. Looks like it will probably go out with #569 :-) |
Fixes: #435
Rebases: #437
Adds two configuration options:
--documentation: A glob for extra documentation to be injected similar to readmes, but also listed in the sidebar.
--abstract: A glob for injecting extra content into matching Abstract group sections.
This is a rough commit. I have no idea what to test in ruby. Would love some suggestions on what to look at next,