[SourceKitten] No longer count initializers with parameters as undocumented #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -13,7 +13,9 @@ | |||
|
|
|||
| ##### Bug Fixes | |||
|
|
|||
| * None. | |||
| * No longer count initializers with parameters as undocumented. | |||
| def declaration? | ||
| kind =~ /^source\.lang\.swift\.decl\..*/ | ||
| end | ||
|
|
||
| def param? | ||
| kind == 'source.lang.swift.decl.var.parameter' || | ||
| kind == 'source.lang.swift.decl.var.local' |
There was a problem hiding this comment.
please add a comment saying why var.local is a param
|
Do we need to add a test to |
|
thanks @jpsim ! 👍 |
|
All good comments, @segiddins. Thanks. |
|
👍 |
jpsim
added a commit
that referenced
this pull request
Mar 23, 2015
[SourceKitten] No longer count initializers with parameters as undocumented
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #183.
Initializers with parameters would be counted additional times for each undocumented parameter (which SourceKit oddly categorizes as local variables instead of parameters). This meant that initializers showed up in
/undocumented.txtand affected code coverage percentage.Care to take a look @segiddins and @jessesquires?