Add empty_parameters rule
#965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
I thought about that, but should rules describe what they catch or what is the "right way"? 💭 |
Current coverage is 81.67% (diff: 92.85%)@@ master #965 diff @@
==========================================
Files 132 134 +2
Lines 6395 6282 -113
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 5227 5131 -96
+ Misses 1168 1151 -17
Partials 0 0
|
Merged
|
I actually like the "Empty Parameters" rule name. |
|
Let's keep then! I'll rebase the changelog |
|
I'll mark this as |
marcelofabri
changed the title
empty_parameters ruleempty_parameters rule
|
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #573
I'm not a big fan of this rule name though 😅