type_name rule now validates typealias and associatedtype
#955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcelofabri
commented
Dec 10, 2016
| "uppercase character and span between 3 and 40 characters in length.", | ||
| nonTriggeringExamples: ["class", "struct", "enum"].flatMap({ type in | ||
| private static func nonTriggeringExamples() -> [String] { | ||
| let typeExamples: [String] = ["class", "struct", "enum"].flatMap { type -> [String] in |
There was a problem hiding this comment.
I added all theses type annotations because it was taking too long to compile 😬
Current coverage is 81.10% (diff: 94.73%)@@ master #955 diff @@
==========================================
Files 123 123
Lines 5774 5838 +64
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 4675 4735 +60
- Misses 1099 1103 +4
Partials 0 0
|
marcelofabri
changed the title
type_name rule now validates typealias tootype_name rule now validates typealias and associatedtype
|
Can you please rebase this so we can confirm it builds and passes tests on Linux? |
|
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #49 and #956