Add uncuddled else support to the statement_position rule #688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 9, 2016 14:35
| case Standard = "standard", UncuddledElse = "uncuddled_else" | ||
|
|
||
| init(value: AnyObject) throws { | ||
| guard let string = (value as? String)?.lowercaseString else { |
There was a problem hiding this comment.
this init is equivalent:
if let string = (value as? String)?.lowercaseString,
value = StatmentModeConfiguration(rawValue: string) {
self = value
} else {
throw ConfigurationError.UnknownConfiguration
}
Current coverage is 90.00%@@ master #688 diff @@
==========================================
Files 71 72 +1
Lines 2238 2351 +113
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 2016 2116 +100
- Misses 222 235 +13
Partials 0 0
|
|
On the whole this looks great @ateliercw! I just have a few comments. An entry in the changelog would be good too. |
- renamed "standard" to "default" - Updated formatting per code review - added note to changelog
|
@jpsim adding the the change log entry made me realize that "default" is a more sensible name than "standard", and I made the other formatting and code tweaks that you requested. |
|
Really great first contribution, @ateliercw! 👏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implements uncuddled else as an option on statement_position including autocorrect, should solve issue #651