Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't trigger ClosingBraceRule across line breaks #605

Merged
merged 1 commit into from
Apr 5, 2016

Conversation

joshfriend
Copy link

Closes #592

@jpsim
Copy link
Collaborator

jpsim commented Apr 5, 2016

Thanks! Could you please add regression tests in nonTriggeringExamples and triggeringExamples?

@joshfriend joshfriend force-pushed the fix-multiline-closing-brace branch from ed60397 to a4d32cf Compare April 5, 2016 18:11
@joshfriend
Copy link
Author

Added! I didn't realize those were test cases...

@jpsim
Copy link
Collaborator

jpsim commented Apr 5, 2016

Thanks for the tests, looks good now!

I didn't realize those were test cases...

That's described a bit in the rules section of our CONTRIBUTING.md document:

All new rules or changes to existing rules should be accompanied by unit tests.

Whenever possible, prefer adding tests via the triggeringExamples and nonTriggeringExamples properties of a rule's description rather than adding those test cases in the unit tests directly. This makes it easier to understand what rules do by reading their source, and simplifies adding more test cases over time.

@jpsim jpsim merged commit 46e8dc8 into realm:master Apr 5, 2016
@joshfriend joshfriend deleted the fix-multiline-closing-brace branch April 5, 2016 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants