Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Started to add rationales #5681

Open
wants to merge 32 commits into
base: main
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
e0930cc
Started to add rationales
mildm8nnered Jul 20, 2024
33fbcd0
Missing separator
mildm8nnered Jul 20, 2024
c45e607
Tweaks
mildm8nnered Jul 20, 2024
bfea45c
Tweaked line endings
mildm8nnered Jul 21, 2024
966ccd0
Wording
mildm8nnered Jul 21, 2024
278aaa6
Attributes
mildm8nnered Jul 21, 2024
3f041c9
Added rationale
mildm8nnered Jul 21, 2024
3cff0d3
Added rationale to Blanket Disable Command
mildm8nnered Jul 21, 2024
a236226
Added more rationale's
mildm8nnered Jul 21, 2024
a48b88c
Fixed typos
mildm8nnered Jul 22, 2024
650c4cd
Documentation update
mildm8nnered Jul 26, 2024
1bad3df
Documentation tweak
mildm8nnered Jul 26, 2024
8ae3d43
Better formatting
mildm8nnered Jul 27, 2024
1120bfd
Better text
mildm8nnered Jul 29, 2024
fd743bd
Fixed line lengths
mildm8nnered Aug 1, 2024
eba9661
Removed indentation
mildm8nnered Aug 1, 2024
9bfa21b
indent markdown multiline code by 4 spaces for the console
mildm8nnered Aug 1, 2024
acb3126
Added more detail
mildm8nnered Aug 11, 2024
ee8e85c
Apply suggestions from code review
mildm8nnered Nov 5, 2024
71bc750
CR comments
mildm8nnered Nov 5, 2024
c2114aa
line length fix
mildm8nnered Nov 18, 2024
9b77478
Fixed some indentation and formatting
mildm8nnered Nov 30, 2024
c4f948c
Warning fix
mildm8nnered Dec 1, 2024
1cd748d
Mention indentation in the comment.
mildm8nnered Dec 1, 2024
b3ac907
Don't indent code at source
mildm8nnered Dec 1, 2024
65da7c5
superfluous else
mildm8nnered Dec 1, 2024
73a1a4a
Improvements
mildm8nnered Dec 1, 2024
61bdcea
Fixed compilation
mildm8nnered Dec 28, 2024
1d46a5b
Fixed indentation
mildm8nnered Dec 30, 2024
646e569
Removed mention of configuration options
mildm8nnered Jan 4, 2025
df36a8c
Added entry
mildm8nnered Jan 4, 2025
0deab21
CR comments
mildm8nnered Jan 11, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Missing separator
mildm8nnered committed Jan 24, 2025
commit 33fbcd07c8bbdb11fd03fa215cb82529002557b3
Original file line number Diff line number Diff line change
@@ -26,7 +26,7 @@ struct ArrayInitRule: Rule, @unchecked Sendable {
```
foo.map { !$0 }
```
"""
""",
kind: .lint,
nonTriggeringExamples: [
Example("Array(foo)"),