Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Trigger superfluous_disable_command for custom_rules" #5339

Merged
merged 1 commit into from
Nov 9, 2023
Merged

Revert "Trigger superfluous_disable_command for custom_rules" #5339

merged 1 commit into from
Nov 9, 2023

Conversation

marcelofabri
Copy link
Collaborator

Reverts #4755

@marcelofabri marcelofabri enabled auto-merge (squash) November 9, 2023 08:46
@SwiftLintBot
Copy link

16 Messages
📖 Linting Aerial with this PR took 1.2s vs 1.21s on main (0% faster)
📖 Linting Alamofire with this PR took 1.58s vs 1.59s on main (0% faster)
📖 Linting Brave with this PR took 9.1s vs 9.14s on main (0% faster)
📖 Linting DuckDuckGo with this PR took 4.55s vs 4.58s on main (0% faster)
📖 Linting Firefox with this PR took 10.59s vs 10.66s on main (0% faster)
📖 Linting Kickstarter with this PR took 11.17s vs 11.17s on main (0% slower)
📖 Linting Moya with this PR took 0.63s vs 0.63s on main (0% slower)
📖 Linting NetNewsWire with this PR took 3.33s vs 3.34s on main (0% faster)
📖 Linting Nimble with this PR took 0.83s vs 0.83s on main (0% slower)
📖 Linting PocketCasts with this PR took 8.99s vs 8.99s on main (0% slower)
📖 Linting Quick with this PR took 0.4s vs 0.4s on main (0% slower)
📖 Linting Realm with this PR took 11.57s vs 11.58s on main (0% faster)
📖 Linting Sourcery with this PR took 2.86s vs 2.87s on main (0% faster)
📖 Linting VLC with this PR took 1.57s vs 1.58s on main (0% faster)
📖 Linting Wire with this PR took 20.04s vs 20.1s on main (0% faster)
📖 Linting WordPress with this PR took 13.57s vs 13.65s on main (0% faster)

Generated by 🚫 Danger

@marcelofabri marcelofabri merged commit ed8ed01 into main Nov 9, 2023
@marcelofabri marcelofabri deleted the revert-4755-marcelo/custom-rules-disable branch November 9, 2023 09:11
u-abyss pushed a commit to u-abyss/SwiftLint that referenced this pull request Dec 16, 2023
@marcelofabri @u-abyss
Revert "Trigger superfluous_disable_command for custom_rules (realm#4755
2b2c021 
)" (realm#5339)

This reverts commit 7499896.
MartijnAmbagtsheer pushed a commit to MartijnAmbagtsheer/SwiftLint that referenced this pull request Dec 20, 2023
@marcelofabri
Revert "Trigger superfluous_disable_command for custom_rules (realm#4755
f414925 
)" (realm#5339)

This reverts commit 7499896.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marcelofabri @SwiftLintBot