Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore case of keywords for valid_docs #506

Merged
merged 1 commit into from
Feb 7, 2016
Merged

Conversation

aciidgh
Copy link
Contributor

@aciidgh aciidgh commented Feb 7, 2016

Fixes #298

@jpsim
Copy link
Collaborator

jpsim commented Feb 7, 2016

Thanks for the contribution! Could you please add a changelog entry following the guidelines in our CONTRIBUTING.md document? Then we'll be able to merge this.

@aciidgh
Copy link
Contributor Author

aciidgh commented Feb 7, 2016

@jpsim Done.

@jpsim
Copy link
Collaborator

jpsim commented Feb 7, 2016

Thanks so much! My testing confirms this behaves as expected, with only a minimal performance impact.

Linting Carthage 0.11 spends 2.673s in valid_docs on SwiftLint master, vs 2.696s in this PR.

Although more generally valid_docs is by far the slowest rule in SwiftLint (followed by colon at 1.5s and function_parameter_count at 0.7s). The rest mostly are all under 0.2s.

jpsim added a commit that referenced this pull request Feb 7, 2016
Ignore case of keywords for valid_docs
@jpsim jpsim merged commit b045621 into realm:master Feb 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants