Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RedundantDiscardableLetRule should not produce warning when used with… #4143

Merged

Conversation

mhosna
Copy link
Contributor

@mhosna mhosna commented Aug 29, 2022

… async

handle situation with async let _ = ....
let can not be removed from "async let _ = ..." because removing it produces invalid swift syntax

… async

handle situation with async let _ = ....
let can not be removed from "async let _ = ..." because removing it produces invalid swift syntax
@SwiftLintBot
Copy link

1 Warning
⚠️ If this is a user-facing change, please include a CHANGELOG entry to credit yourself!
You can find it at CHANGELOG.md.
12 Messages
📖 Linting Aerial with this PR took 0.33s vs 0.33s on master (0% slower)
📖 Linting Alamofire with this PR took 0.34s vs 0.34s on master (0% slower)
📖 Linting Firefox with this PR took 1.37s vs 1.37s on master (0% slower)
📖 Linting Kickstarter with this PR took 1.91s vs 1.92s on master (0% faster)
📖 Linting Moya with this PR took 0.22s vs 0.22s on master (0% slower)
📖 Linting Nimble with this PR took 0.22s vs 0.22s on master (0% slower)
📖 Linting Quick with this PR took 0.15s vs 0.15s on master (0% slower)
📖 Linting Realm with this PR took 1.17s vs 1.18s on master (0% faster)
📖 Linting SourceKitten with this PR took 0.21s vs 0.21s on master (0% slower)
📖 Linting Sourcery with this PR took 0.53s vs 0.53s on master (0% slower)
📖 Linting Swift with this PR took 0.94s vs 0.93s on master (1% slower)
📖 Linting WordPress with this PR took 2.17s vs 2.17s on master (0% slower)

Here's an example of your CHANGELOG entry:

* RedundantDiscardableLetRule should not produce warning when used with….  
  [mhosna](https://github.com/mhosna)
  [#issue_number](https://github.com/realm/SwiftLint/issues/issue_number)

note: There are two invisible spaces after the entry's text.

Generated by 🚫 Danger

@jpsim jpsim enabled auto-merge (squash) August 29, 2022 16:56
@jpsim jpsim disabled auto-merge August 29, 2022 16:56
@jpsim jpsim merged commit f32bc1f into realm:master Aug 29, 2022
jpsim added a commit that referenced this pull request Aug 29, 2022
jpsim added a commit that referenced this pull request Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants