Add SwiftSyntax rule helpers #4126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
jpsim
changed the title
SimplyDanny
approved these changes
Aug 25, 2022
This reverts commit 332ab50. This had poor performance impact
jpsim
force-pushed
the
prototype-swiftsyntax-rule-conveniences
branch
from
07023bf to
6c63a78
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cuts down on the boilerplate involved in writing SwiftSyntax-based rules. May not be significant right now since most rules are still built with SourceKit, but as we migrate more rules moving forward, this should make it easier for rule authors to write rules that behave performantly and correctly.