Skip braces in regex literals #4091
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
|
Alternatively, here's a SwifSyntax implementation that I think mostly works, I just haven't implemented corrections yet: https://github.com/realm/SwiftLint/compare/jp-closure-spacing-rule-swift-syntax Feel free to pick it up if you have time, otherwise I can probably finish it later this week. |
5 tasks
Looks good to me so far!
I'll let you know once I find the time to continue with it. |
|
#4092 is ready to go now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a workaround for the false positive reported in #4090.
Regex literals will only be supported in Swift 6. For that reason, SourceKit does not yet know anything about the syntax type "Regex Literal". The correct fix would be skipping regex literals completely in the rule like it is done for strings and comments.
The lookarounds in the regex to find the braces make the rule significantly slower as we see in the report below.