Update SwiftSyntax to 0.50600.0 #3901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpsim
force-pushed
the
update-swiftsyntax-to-0.50600.0
branch
from
7e400e0 to
b60cf2d
Compare
Here's an example of your CHANGELOG entry: * Update SwiftSyntax to 0.50600.0.
[jpsim](https://github.com/jpsim)
[#issue_number](https://github.com/realm/SwiftLint/issues/issue_number)note: There are two invisible spaces after the entry's text. Generated by 🚫 Danger |
Codecov Report
@@ Coverage Diff @@
## master #3901 +/- ##
==========================================
+ Coverage 92.60% 92.61% +0.01%
==========================================
Files 436 436
Lines 21964 21964
==========================================
+ Hits 20339 20342 +3
+ Misses 1625 1622 -3
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
|
Reported the TSan error here: https://bugs.swift.org/browse/SR-16004 |
To better separate the steps in the CI job
This reverts commit 60d29b4. It worked: https://github.com/realm/SwiftLint/pkgs/container/swiftlint/17003323?tag=preview
This actually works now.
jpsim
added a commit
that referenced
this pull request
Mar 17, 2022
Uses SwiftSyntax 5.5 on Linux when building with Swift 5.5. We use the 5.6 version of SwiftSyntax when building with Swift 5.5 and 5.6 on macOS because we statically link `lib_InternalSwiftSyntaxParser` thanks to https://github.com/keith/StaticInternalSwiftSyntaxParser/releases/tag/5.6. This keeps SwiftLint binaries portable across machines on macOS, regardless of _where_ or even _if_ `lib_InternalSwiftSyntaxParser` is installed. * Run TSan CI job with `--configuration release` to avoid stack overflows * Add Swift 5.6 CI job * Fix linker settings
coffmark
pushed a commit
to coffmark/SwiftLint
that referenced
this pull request
Apr 11, 2022
Uses SwiftSyntax 5.5 on Linux when building with Swift 5.5. We use the 5.6 version of SwiftSyntax when building with Swift 5.5 and 5.6 on macOS because we statically link `lib_InternalSwiftSyntaxParser` thanks to https://github.com/keith/StaticInternalSwiftSyntaxParser/releases/tag/5.6. This keeps SwiftLint binaries portable across machines on macOS, regardless of _where_ or even _if_ `lib_InternalSwiftSyntaxParser` is installed. * Run TSan CI job with `--configuration release` to avoid stack overflows * Add Swift 5.6 CI job * Fix linker settings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses SwiftSyntax 5.5 on Linux when building with Swift 5.5. We use the 5.6 version of SwiftSyntax when building with Swift 5.5 and 5.6 on macOS because we statically link
lib_InternalSwiftSyntaxParserthanks to https://github.com/keith/StaticInternalSwiftSyntaxParser/releases/tag/5.6.This keeps SwiftLint binaries portable across machines on macOS, regardless of where or even if
lib_InternalSwiftSyntaxParseris installed.