Add ControlStatementRule #39
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,62 @@ | ||
| // | ||
| // ControlStatementRule.swift | ||
| // SwiftLint | ||
| // | ||
| // Created by Andrea Mazzini on 26/05/15. | ||
| // Copyright (c) 2015 Realm. All rights reserved. | ||
| // | ||
|
|
||
| import SourceKittenFramework | ||
|
|
||
| public struct ControlStatementRule: Rule { | ||
| public init() {} | ||
|
|
||
| public let identifier = "control_statement" | ||
|
|
||
| public func validateFile(file: File) -> [StyleViolation] { | ||
| let statement = file.matchPattern("\\s{0,}(if|for|while)\\s{0,}\\(", | ||
| withSyntaxKinds: [.Keyword]) | ||
| return statement.map { range in | ||
| return StyleViolation(type: .ControlStatement, | ||
| location: Location(file: file, offset: range.location), | ||
| severity: .Low, | ||
| reason: "if,for,while,do statements shouldn't wrap their conditionals in parentheses.") | ||
| } | ||
| } | ||
|
|
||
| public let example = RuleExample( | ||
| ruleName: "Control Statement", | ||
| ruleDescription: "if,for,while,do statements shouldn't wrap their conditionals in parentheses.", | ||
| nonTriggeringExamples: [ | ||
| "if condition {\n", | ||
| "renderGif(data)\n", | ||
| "// if (hasBetterSyntax) {\n", | ||
| "// for (item in collection) {\n", | ||
| "// for (var index = 0; index < 42; index++) {\n", | ||
| "// for(item in collection) {\n", | ||
| "// for(var index = 0; index < 42; index++) {\n", | ||
| "for item in collection {\n", | ||
| "for var index = 0; index < 42; index++ {\n", | ||
| "// while (condition) {\n", | ||
| "while condition {\n", | ||
| "} while condition {\n", | ||
| "// } while (condition {\n", | ||
| "do { ; } while condition {\n" | ||
| ], | ||
| triggeringExamples: [ | ||
| "if (condition) {\n", | ||
| "if(condition) {\n", | ||
| "for (item in collection) {\n", | ||
| "for (var index = 0; index < 42; index++) {\n", | ||
| "for(item in collection) {\n", | ||
| "for(var index = 0; index < 42; index++) {\n", | ||
| "while (condition) {\n", | ||
| "while(condition) {\n", | ||
| "} while (condition) {\n", | ||
| "} while(condition) {\n", | ||
| "do { ; } while(condition) {\n", | ||
| "do { ; } while (condition) {\n" | ||
| ] | ||
| ) | ||
| } | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should probably use the regex match for the specific keyword instead of listing them all