Fix make package command #3890
Merged
Fix make package command #3890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Verified installing the package in a fresh macOS 12.2.1 VM only installs a single
|
|
Can you please take a look @miketimofeev & @jberkel? |
jpsim
commented
Mar 10, 2022
| --root "$(TEMPORARY_FOLDER)" \ | ||
| --version "$(VERSION_STRING)" \ | ||
| --root "$(PACKAGE_ROOT)" \ | ||
| --version $(VERSION_STRING) \ |
There was a problem hiding this comment.
This was previously being double-quoted
Codecov Report
@@ Coverage Diff @@
## master #3890 +/- ##
==========================================
- Coverage 91.99% 91.99% -0.01%
==========================================
Files 435 435
Lines 22074 22074
==========================================
- Hits 20307 20306 -1
- Misses 1767 1768 +1
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
jpsim
added a commit
that referenced
this pull request
Mar 16, 2022
coffmark
pushed a commit
to coffmark/SwiftLint
that referenced
this pull request
Apr 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3815
Fixes #3887