Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use SwiftSyntax visitor to parse commands #3872

Merged
merged 5 commits into from
Mar 8, 2022
Merged

Conversation

jpsim
Copy link
Collaborator

@jpsim jpsim commented Mar 7, 2022

No description provided.

@SwiftLintBot
Copy link

SwiftLintBot commented Mar 7, 2022

1 Warning
⚠️ This PR may need tests.
12 Messages
📖 Linting Aerial with this PR took 0.94s vs 1.02s on master (7% faster)
📖 Linting Alamofire with this PR took 1.06s vs 1.03s on master (2% slower)
📖 Linting Firefox with this PR took 3.87s vs 3.68s on master (5% slower)
📖 Linting Kickstarter with this PR took 7.04s vs 6.78s on master (3% slower)
📖 Linting Moya with this PR took 4.35s vs 4.38s on master (0% faster)
📖 Linting Nimble with this PR took 0.38s vs 0.4s on master (5% faster)
📖 Linting Quick with this PR took 0.16s vs 0.18s on master (11% faster)
📖 Linting Realm with this PR took 5.94s vs 6.54s on master (9% faster)
📖 Linting SourceKitten with this PR took 0.32s vs 0.32s on master (0% slower)
📖 Linting Sourcery with this PR took 1.82s vs 1.91s on master (4% faster)
📖 Linting Swift with this PR took 3.05s vs 2.92s on master (4% slower)
📖 Linting WordPress with this PR took 7.11s vs 6.91s on master (2% slower)

Generated by 🚫 Danger

@jpsim jpsim merged commit 28dd673 into master Mar 8, 2022
@jpsim jpsim deleted the swift-syntax-commands branch March 8, 2022 17:33
jpsim added a commit that referenced this pull request Mar 9, 2022
* Cache SwiftSyntax syntax trees
* Use SwiftSyntax visitor to parse commands
* Update changelog entry
* Cache commands
coffmark pushed a commit to coffmark/SwiftLint that referenced this pull request Apr 11, 2022
* Cache SwiftSyntax syntax trees
* Use SwiftSyntax visitor to parse commands
* Update changelog entry
* Cache commands
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants