Add caching of Structure and SyntaxMap. #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no need to read them individually for every rule. This cuts execution time by more than 50%.
|
Thanks, yeah the initial implementation was very naive, but the tool ran quickly enough in my tests for it not to bother me too much. I agree it would be cleaner to make a type for this which could get passed around instead of Nice work! 🎉 |
jpsim
added a commit
that referenced
this pull request
May 26, 2015
Add caching of Structure and SyntaxMap.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no need to read them individually for every rule.
This cuts execution time by more than 50%.
I've designed the change to be minimally-invasive. Alternatively, I think it might be cleaner to pass a pre-filled custom struct into
ASTRuleinstead ofSourceKitten.File.