Optimize File.matchPattern(_:) -> [(NSRange, [SyntaxKind])]
#263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change from converting match's position to converting token's position. By applying this, duration of linting KeychainAccess is reduced from 752+sec(I can't wait completion) to 27sec.
|
|
||
| * Make linting faster than 0.5.0, but slower than 0.4.0 | ||
| [Norio Nomura](https://github.com/norio-nomura) | ||
| [#263](https://github.com/realm/SwiftLint/pull/263) |
There was a problem hiding this comment.
please refer to issues fixed rather than this PR's number here, as outlined in CONTRIBUTING.md.
There was a problem hiding this comment.
Should I create an issue on SwiftLint or refer to jpsim/SourceKitten#119 ?
There was a problem hiding this comment.
You can refer to the SourceKitten issue, you can refer to other changelog entries for the format there.
|
Other than naming 👍 |
|
Thank you for reviews! |
|
👍 big thanks for this! |
jpsim
added a commit
that referenced
this pull request
Dec 14, 2015
Optimize `File.matchPattern(_:) -> [(NSRange, [SyntaxKind])]`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change from converting match's position to converting token's position.
By applying this, duration of linting KeychainAccess is reduced from 752+sec(I can't wait completion) to 27sec, but still slower that 0.4.0 (7 sec).
Related: jpsim/SourceKitten#119