Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash when saving cache #2109

Merged
merged 1 commit into from
Mar 25, 2018
Merged

Fix crash when saving cache #2109

merged 1 commit into from
Mar 25, 2018

Conversation

marcelofabri
Copy link
Collaborator

Fixes #2032

@SwiftLintBot
Copy link

12 Messages
📖 Linting Aerial with this PR took 0.43s vs 0.41s on master (4% slower)
📖 Linting Alamofire with this PR took 3.46s vs 3.52s on master (1% faster)
📖 Linting Firefox with this PR took 14.1s vs 14.06s on master (0% slower)
📖 Linting Kickstarter with this PR took 21.29s vs 21.72s on master (1% faster)
📖 Linting Moya with this PR took 1.98s vs 2.05s on master (3% faster)
📖 Linting Nimble with this PR took 1.97s vs 1.99s on master (1% faster)
📖 Linting Quick with this PR took 0.6s vs 0.59s on master (1% slower)
📖 Linting Realm with this PR took 3.82s vs 3.9s on master (2% faster)
📖 Linting SourceKitten with this PR took 1.24s vs 1.22s on master (1% slower)
📖 Linting Sourcery with this PR took 5.13s vs 5.17s on master (0% faster)
📖 Linting Swift with this PR took 17.06s vs 17.4s on master (1% faster)
📖 Linting WordPress with this PR took 17.17s vs 17.38s on master (1% faster)

Generated by 🚫 Danger

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@c87b2c7). Click here to learn what that means.
The diff coverage is 80.95%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master   #2109   +/-   ##
========================================
  Coverage          ?   89.8%           
========================================
  Files             ?     264           
  Lines             ?   15275           
  Branches          ?     997           
========================================
  Hits              ?   13717           
  Misses            ?    1539           
  Partials          ?      19
Impacted Files Coverage Δ
...sts/SwiftLintFrameworkTests/LinterCacheTests.swift 98.62% <100%> (ø)
Source/SwiftLintFramework/Models/LinterCache.swift 80.26% <60%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c87b2c7...ae0e21f. Read the comment docs.

@marcelofabri marcelofabri merged commit 941a548 into realm:master Mar 25, 2018
@marcelofabri marcelofabri deleted the bugfix-2032 branch March 25, 2018 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants