Make legacy_constructor rule more reliable

[marcelofabri]

Fixes #2098

[SwiftLintBot]

	1 Warning
⚠️	This PR may need tests.

	12 Messages
📖	Linting Aerial with this PR took 0.45s vs 0.41s on master (9% slower)
📖	Linting Alamofire with this PR took 3.53s vs 3.47s on master (1% slower)
📖	Linting Firefox with this PR took 14.16s vs 14.08s on master (0% slower)
📖	Linting Kickstarter with this PR took 21.24s vs 21.48s on master (1% faster)
📖	Linting Moya with this PR took 2.04s vs 2.05s on master (0% faster)
📖	Linting Nimble with this PR took 1.98s vs 1.99s on master (0% faster)
📖	Linting Quick with this PR took 0.58s vs 0.59s on master (1% faster)
📖	Linting Realm with this PR took 3.84s vs 3.96s on master (3% faster)
📖	Linting SourceKitten with this PR took 1.21s vs 1.23s on master (1% faster)
📖	Linting Sourcery with this PR took 5.21s vs 4.99s on master (4% slower)
📖	Linting Swift with this PR took 15.14s vs 14.54s on master (4% slower)
📖	Linting WordPress with this PR took 17.22s vs 17.11s on master (0% slower)

Generated by 🚫 Danger

[codecov-io]

Codecov Report

Merging #2102 into master will increase coverage by <.01%.
The diff coverage is 96.47%.

@@            Coverage Diff             @@
##           master    #2102      +/-   ##
==========================================
+ Coverage   89.72%   89.73%   +<.01%     
==========================================
  Files         262      262              
  Lines       15059    15117      +58     
  Branches      979      981       +2     
==========================================
+ Hits        13512    13565      +53     
- Misses       1530     1534       +4     
- Partials       17       18       +1

Impacted Files	Coverage Δ
...iftLintFramework/Rules/LegacyConstructorRule.swift	96.73% <96.47%> (-3.27%)	⬇️
Source/SwiftLintFramework/Models/Command.swift	95.65% <0%> (-2.18%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b34b4b...e810689. Read the comment docs.