Fix TODOs violation message

[isadon]

Change lint message for TODOs/FIXMEs to state that they should be
"resolved"/implemented instead of "avoided"/not used.

[SwiftLintBot]

	2543 Warnings
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Account/FxADeviceRegistration.swift:168:20: warning: Todo Violation: TODOs should be resolved (Should be in an "I have an iOS…). (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Account/FxALoginStateMachine.swift:11:4: warning: Todo Violation: TODOs should be resolved (log to an FxA-only, persistent…). (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Account/FxALoginStateMachine.swift:14:4: warning: Todo Violation: TODOs should be resolved (fill this in!). (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Account/FxAClient10.swift:526:69: warning: Todo Violation: TODOs should be resolved (debate key size and extract th…). (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Client/Frontend/Browser/BrowserViewController/BrowserViewController+WKNavigationDelegate.swift:99:37: warning: Todo Violation: TODOs should be resolved (Is this the same as isWhitelis…). (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Client/Frontend/Browser/OpenSearch.swift:249:12: warning: Todo Violation: TODOs should be resolved (For now, just use the largest …). (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Client/Frontend/Browser/SearchLoader.swift:14:4: warning: Todo Violation: TODOs should be resolved (Swift currently requires that …). (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Client/Frontend/Browser/SearchViewController.swift:20:8: warning: Todo Violation: TODOs should be resolved (This should use ToolbarHeight …). (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Client/Frontend/Browser/Tab.swift:73:62: warning: Todo Violation: TODOs should be resolved (generalize this.). (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Client/Frontend/Browser/BrowserViewController.swift:102:8: warning: Todo Violation: TODOs should be resolved (weak references?). (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Client/Frontend/Browser/BrowserViewController.swift:1217:4: warning: Todo Violation: TODOs should be resolved (this should be expanded to tra…). (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Client/Frontend/Browser/BrowserViewController.swift:1339:16: warning: Todo Violation: TODOs should be resolved (https://bugzilla.mozilla.org/s…). (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Client/Frontend/Browser/BrowserViewController.swift:1706:42: warning: Todo Violation: TODOs should be resolved (UX Right now the flow for sign…). (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Client/Frontend/Browser/BrowserViewController.swift:1710:42: warning: Todo Violation: TODOs should be resolved (UX Right now the flow for sign…). (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Client/Frontend/Browser/BrowserViewController.swift:2251:81: warning: Todo Violation: TODOs should be resolved (Check result, can this fail?). (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Client/Frontend/Browser/BrowserViewController.swift:2259:80: warning: Todo Violation: TODOs should be resolved (Check result, can this fail?). (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Client/Frontend/Browser/BrowserViewController.swift:2268:141: warning: Todo Violation: TODOs should be resolved (Check result, can this fail?). (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Client/Frontend/Browser/BrowserViewController.swift:2278:66: warning: Todo Violation: TODOs should be resolved (Check result, can this fail?). (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Client/Frontend/ContentBlocker/ContentBlockerSettingViewController.swift:16:12: warning: Todo Violation: TODOs should be resolved (Get a dedicated string for thi…). (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Client/Frontend/ContentBlocker/ContentBlockerHelper.swift:383:12: warning: Todo Violation: TODOs should be resolved (Not done). (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Client/Frontend/Home/BookmarksPanel.swift:414:16: warning: Todo Violation: TODOs should be resolved (check whether the folder is em…). (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Client/Frontend/Home/ReaderPanel.swift:118:113: warning: Todo Violation: TODOs should be resolved (Not clear from ux spec). (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Client/Frontend/Home/ReaderPanel.swift:429:20: warning: Todo Violation: TODOs should be resolved (This is a bit odd because the …). (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Client/Frontend/Reader/ReadabilityService.swift:67:24: warning: Todo Violation: TODOs should be resolved (Fail). (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Client/Frontend/Reader/ReadabilityService.swift:70:20: warning: Todo Violation: TODOs should be resolved (Not entitely sure what to do o…). (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Client/Frontend/Home/RemoteTabsPanel.swift:24:71: warning: Todo Violation: TODOs should be resolved (I set this to 8 so that it all…). (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Client/Frontend/Home/RemoteTabsPanel.swift:203:12: warning: Todo Violation: TODOs should be resolved (Bug 1144765 - Populate image w…). (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Client/Frontend/Reader/ReaderModeHandlers.swift:78:67: warning: Todo Violation: TODOs should be resolved (Needs a proper error page). (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Client/Frontend/Reader/ReaderModeStyleViewController.swift:17:64: warning: Todo Violation: TODOs should be resolved (THis needs to be 44% of 0x3333…). (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Client/Frontend/Reader/ReaderModeStyleViewController.swift:22:71: warning: Todo Violation: TODOs should be resolved (THis needs to be 44% of 0x3333…). (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Client/Frontend/Reader/ReaderModeStyleViewController.swift:307:12: warning: Todo Violation: TODOs should be resolved (Does this need to change with …). (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Client/Frontend/Reader/ReaderModeStyleViewController.swift:323:12: warning: Todo Violation: TODOs should be resolved. (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Client/Frontend/Widgets/TwoLineCell.swift:175:8: warning: Todo Violation: TODOs should be resolved (Not ideal. We should figure ou…). (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Client/Helpers/UserActivityHandler.swift:25:56: warning: Todo Violation: TODOs should be resolved (Bug 1390294). (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Client/Helpers/FxALoginHelper.swift:117:20: warning: Todo Violation: TODOs should be resolved (add UI to tell the user to go …). (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Client/Helpers/FxALoginHelper.swift:335:12: warning: Todo Violation: TODOs should be resolved (fix Bug 1168690, to tell Sync …). (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Client/Frontend/Widgets/PhotonActionSheetProtocol.swift:75:6: warning: Todo Violation: TODOs should be resolved (These icons should all have th…). (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Client/Frontend/Widgets/PhotonActionSheetProtocol.swift:139:15: warning: Todo Violation: TODOs should be resolved (can all this logic go somewher…). (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Client/Frontend/Widgets/PhotonActionSheetProtocol.swift:156:15: warning: Todo Violation: TODOs should be resolved (can all this logic go somewher…). (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Client/Frontend/Widgets/PhotonActionSheetProtocol.swift:270:16: warning: Todo Violation: TODOs should be resolved (Enable Tracking protection for…). (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Extensions/SendTo/InstructionsViewController.swift:93:33: warning: Todo Violation: TODOs should be resolved (Not sure what to do or if to k…). (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Extensions/SendTo/ClientPickerViewController.swift:312:32: warning: Todo Violation: TODOs should be resolved (We used to have a 'show me how…). (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Extensions/ShareTo/InitialViewController.swift:17:73: warning: Todo Violation: TODOs should be resolved (Is the correct color documente…). (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Extensions/ShareTo/InitialViewController.swift:82:8: warning: Todo Violation: TODOs should be resolved (use Set.). (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Extensions/ShareTo/InitialViewController.swift:117:31: warning: Todo Violation: TODOs should be resolved (Why does UILayoutPriorityRequi…). (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Extensions/ShareTo/ShareViewController.swift:15:4: warning: Todo Violation: TODOs should be resolved (See if we can do this with an …). (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Extensions/ShareTo/ShareViewController.swift:105:47: warning: Todo Violation: TODOs should be resolved (Can go away if icon is provide…). (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Extensions/ShareTo/ShareViewController.swift:168:12: warning: Todo Violation: TODOs should be resolved (See Bug 1102516 - Use Snappy t…). (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Providers/NSUserDefaultsPrefs.swift:129:12: warning: Todo Violation: TODOs should be resolved (userDefaults.removePersistentD…). (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Providers/SyncStatusResolver.swift:105:12: warning: Todo Violation: TODOs should be resolved (Instead of finding the worst o…). (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/ReadingList/ReadingListError.swift:8:4: warning: Todo Violation: TODOs should be resolved (This needs to encapsulate an N…). (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/ReadingList/ReadingListFetchSpec.swift:7:4: warning: Todo Violation: TODOs should be resolved (This should really use NSURLCo…). (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/ReadingList/ReadingListRecord.swift:7:4: warning: Todo Violation: TODOs should be resolved (This is not used anymore. Deci…). (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/ReadingList/ReadingListRecordResponse.swift:15:16: warning: Todo Violation: TODOs should be resolved (On Android we call super.wasSu…). (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/ReadingList/ReadingListClient.swift:18:46: warning: Todo Violation: TODOs should be resolved (Should really call this NotMod…). (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/ReadingList/ReadingListClient.swift:26:46: warning: Todo Violation: TODOs should be resolved (Should really call this NotMod…). (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/ReadingList/ReadingListClient.swift:76:16: warning: Todo Violation: TODOs should be resolved (???). (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/ReadingList/ReadingListClient.swift:101:16: warning: Todo Violation: TODOs should be resolved (???). (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/ReadingList/ReadingListClient.swift:116:39: warning: Todo Violation: TODOs should be resolved (Should we have different resul…). (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/ReadingList/ReadingListClient.swift:171:16: warning: Todo Violation: TODOs should be resolved (???). (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/ReadingList/ReadingListClient.swift:198:18: warning: Todo Violation: TODOs should be resolved (Handle errors here). (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/ReadingList/ReadingListRecordsResponse.swift:15:16: warning: Todo Violation: TODOs should be resolved (On Android we call super.wasSu…). (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/ReadingList/ReadingListResponse.swift:9:5: warning: Todo Violation: TODOs should be resolved (In the Android code this is a …). (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/ReadingList/ReadingListSynchronizer.swift:28:12: warning: Todo Violation: TODOs should be resolved (Check if we are already syncin…). (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/ReadingList/ReadingListSynchronizer.swift:29:12: warning: Todo Violation: TODOs should be resolved (If this is a first time sync t…). (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/ReadingList/ReadingListSynchronizer.swift:30:12: warning: Todo Violation: TODOs should be resolved (Check if the client is configu…). (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/ReadingList/ReadingListSQLStorage.swift:39:45: warning: Todo Violation: TODOs should be resolved (Unique but may be null?). (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Shared/Bytes.swift:45:11: warning: Todo Violation: TODOs should be resolved. (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Providers/Profile.swift:1206:16: warning: Todo Violation: TODOs should be resolved (recognize .NotStarted.). (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Providers/Profile.swift:1226:16: warning: Todo Violation: TODOs should be resolved (recognize .NotStarted.). (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Shared/KeychainCache.swift:57:12: warning: Todo Violation: TODOs should be resolved (PII logging.). (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Storage/Clients.swift:59:4: warning: Todo Violation: TODOs should be resolved (should this really compare tab…). (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Storage/Bookmarks/Bookmarks.swift:17:8: warning: Todo Violation: TODOs should be resolved. (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Storage/Bookmarks/Bookmarks.swift:137:8: warning: Todo Violation: TODOs should be resolved (We don't create outbound recor…). (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Storage/Bookmarks/Bookmarks.swift:364:12: warning: Todo Violation: TODOs should be resolved (this should never be nil!). (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Storage/History.swift:96:4: warning: Todo Violation: TODOs should be resolved (integrate Site with this.). (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Storage/MockLogins.swift:88:12: warning: Todo Violation: TODOs should be resolved. (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Storage/MockLogins.swift:93:12: warning: Todo Violation: TODOs should be resolved. (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Storage/MockLogins.swift:98:12: warning: Todo Violation: TODOs should be resolved. (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Storage/MockLogins.swift:142:8: warning: Todo Violation: TODOs should be resolved. (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Storage/Site.swift:30:4: warning: Todo Violation: TODOs should be resolved (Site shouldn't have all of the…). (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Storage/SQL/LoginsSchema.swift:41:8: warning: Todo Violation: TODOs should be resolved (transaction.). (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Storage/SQL/LoginsSchema.swift:108:12: warning: Todo Violation: TODOs should be resolved (real update!). (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Storage/Logins.swift:344:8: warning: Todo Violation: TODOs should be resolved (it's possible that we'll have,…). (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Storage/SQL/BrowserSchema.swift:160:8: warning: Todo Violation: TODOs should be resolved (transaction.). (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Storage/SQL/BrowserSchema.swift:498:8: warning: Todo Violation: TODOs should be resolved (phrase this without the subsel…). (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Storage/SQL/BrowserSchema.swift:520:8: warning: Todo Violation: TODOs should be resolved (phrase this without the subsel…). (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Storage/SQL/BrowserSchema.swift:949:16: warning: Todo Violation: TODOs should be resolved (trigger a sync?). (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Storage/SQL/SQLiteBookmarksModel.swift:412:12: warning: Todo Violation: TODOs should be resolved (Yes, this can be done in one g…). (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Storage/SQL/SQLiteBookmarksModel.swift:540:12: warning: Todo Violation: TODOs should be resolved (bump the parent's modified tim…). (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Storage/SQL/SQLiteBookmarksModel.swift:588:12: warning: Todo Violation: TODOs should be resolved (share this logic with SQLiteHi…). (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Storage/SQL/SQLiteBookmarksModel.swift:600:68: warning: Todo Violation: TODOs should be resolved. (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Storage/SQL/SQLiteBookmarksModel.swift:692:12: warning: Todo Violation: TODOs should be resolved. (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Storage/SQL/SQLiteBookmarksModel.swift:722:25: warning: Todo Violation: TODOs should be resolved. (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Storage/SQL/SQLiteHistory.swift:82:8: warning: Todo Violation: TODOs should be resolved (this can probably be improved.). (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Storage/SQL/SQLiteHistory.swift:213:13: warning: Todo Violation: TODOs should be resolved (remove the LEFT JOIN to fill i…). (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Storage/SQL/SQLiteHistory.swift:316:12: warning: Todo Violation: TODOs should be resolved (make is_bookmarked here accura…). (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Storage/SQL/SQLiteHistory.swift:317:12: warning: Todo Violation: TODOs should be resolved (ensure that the same URL doesn…). (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Storage/SQL/SQLiteHistory.swift:506:8: warning: Todo Violation: TODOs should be resolved (thread siteID into this to avo…). (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Storage/SQL/SQLiteHistory.swift:712:8: warning: Todo Violation: TODOs should be resolved. (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Storage/SQL/SQLiteHistory.swift:800:74: warning: Todo Violation: TODOs should be resolved ()). (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Storage/SQL/SQLiteRemoteClientsAndTabs.swift:33:58: warning: Todo Violation: TODOs should be resolved (find a way to make this less d…). (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Storage/SQL/SQLiteRemoteClientsAndTabs.swift:111:12: warning: Todo Violation: TODOs should be resolved (insert multiple clients in a s…). (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Storage/SQL/SQLiteRemoteClientsAndTabs.swift:379:12: warning: Todo Violation: TODOs should be resolved (Bug 1168690 - delete our clien…). (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Storage/SQL/SQLiteBookmarksSyncing.swift:202:12: warning: Todo Violation: TODOs should be resolved (these can be merged into a sin…). (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Storage/SQL/SQLiteBookmarksSyncing.swift:392:45: warning: Todo Violation: TODOs should be resolved (batch the inserts!)). (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Storage/SQL/SQLiteLogins.swift:565:12: warning: Todo Violation: TODOs should be resolved (these steps can be done in a s…). (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Storage/SQL/SQLiteLogins.swift:566:12: warning: Todo Violation: TODOs should be resolved (if there's no mirror record, a…). (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Storage/SQL/SQLiteLogins.swift:719:58: warning: Todo Violation: TODOs should be resolved (proper host/port check after f…). (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Storage/SQL/SQLiteLogins.swift:737:20: warning: Todo Violation: TODOs should be resolved (join against the mirror table …). (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Storage/SQL/SQLiteLogins.swift:876:8: warning: Todo Violation: TODOs should be resolved (is this safe for a regular res…). (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Storage/Visit.swift:118:8: warning: Todo Violation: TODOs should be resolved (compare Site.). (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Sync/ClientPayload.swift:56:8: warning: Todo Violation: TODOs should be resolved (version, protocols.). (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Sync/HistoryPayload.swift:28:57: warning: Todo Violation: TODOs should be resolved (validate URI.). (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Sync/HistoryPayload.swift:75:16: warning: Todo Violation: TODOs should be resolved (compare visits.). (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Sync/KeysPayload.swift:51:12: warning: Todo Violation: TODOs should be resolved (check collections.). (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Sync/BookmarkPayload.swift:153:16: warning: Todo Violation: TODOs should be resolved (these might need to be weakene…). (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Sync/BookmarkPayload.swift:206:16: warning: Todo Violation: TODOs should be resolved (these might need to be weakene…). (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Sync/BookmarkPayload.swift:284:16: warning: Todo Violation: TODOs should be resolved (these might need to be weakene…). (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Sync/BookmarkPayload.swift:340:12: warning: Todo Violation: TODOs should be resolved (compare optional fields.). (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Sync/BookmarkPayload.swift:374:16: warning: Todo Violation: TODOs should be resolved (these might need to be weakene…). (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Sync/LoginPayload.swift:151:16: warning: Todo Violation: TODOs should be resolved (optional fields.). (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Sync/Record.swift:46:8: warning: Todo Violation: TODOs should be resolved (consider using error tuples.). (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Sync/Record.swift:70:12: warning: Todo Violation: TODOs should be resolved (modified, sortindex, ttl). (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Sync/KeyBundle.swift:169:8: warning: Todo Violation: TODOs should be resolved (how much do we want to move th…). (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Sync/Synchronizers/Bookmarks/BookmarksDownloader.swift:75:8: warning: Todo Violation: TODOs should be resolved. (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Sync/Synchronizers/Bookmarks/BookmarksDownloader.swift:79:8: warning: Todo Violation: TODOs should be resolved. (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Sync/State.swift:191:4: warning: Todo Violation: TODOs should be resolved (the Scratchpad needs to be loa…). (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Sync/State.swift:424:12: warning: Todo Violation: TODOs should be resolved (I think a new keyLabel is un…). (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Sync/Synchronizers/Bookmarks/Merging.swift:15:8: warning: Todo Violation: TODOs should be resolved (this should probably return a …). (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Sync/Synchronizers/Bookmarks/BookmarksSynchronizer.swift:441:12: warning: Todo Violation: TODOs should be resolved. (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Sync/Synchronizers/Bookmarks/BookmarksSynchronizer.swift:455:12: warning: Todo Violation: TODOs should be resolved. (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Sync/Synchronizers/Bookmarks/BookmarksSynchronizer.swift:489:16: warning: Todo Violation: TODOs should be resolved (the presence of empty desktop …). (todo)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Sync/StorageClient.swift:303:4: warning: Todo Violation: TODOs should be resolved (don't be so naïve. Use a combi…). (todo)
⚠️	Danger found 2543 violations with this PR. Due to GitHub's max issue comment size, the number shown has been truncated to 134.

	2555 Messages
📖	Linting Aerial with this PR took 0.43s vs 0.44s on master (2% faster)
📖	Linting Alamofire with this PR took 3.57s vs 3.49s on master (2% slower)
📖	Linting Firefox with this PR took 13.93s vs 14.02s on master (0% faster)
📖	Linting Kickstarter with this PR took 21.86s vs 21.57s on master (1% slower)
📖	Linting Moya with this PR took 2.03s vs 2.09s on master (2% faster)
📖	Linting Nimble with this PR took 1.95s vs 2.03s on master (3% faster)
📖	Linting Quick with this PR took 0.58s vs 0.6s on master (3% faster)
📖	Linting Realm with this PR took 3.76s vs 3.91s on master (3% faster)
📖	Linting SourceKitten with this PR took 1.18s vs 1.17s on master (0% slower)
📖	Linting Sourcery with this PR took 5.19s vs 5.3s on master (2% faster)
📖	Linting Swift with this PR took 14.63s vs 15.01s on master (2% faster)
📖	Linting WordPress with this PR took 16.56s vs 16.07s on master (3% slower)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Account/FxADeviceRegistration.swift:168:20: warning: Todo Violation: TODOs should be avoided (Should be in an "I have an iOS…). (todo)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Account/FxALoginStateMachine.swift:11:4: warning: Todo Violation: TODOs should be avoided (log to an FxA-only, persistent…). (todo)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Account/FxALoginStateMachine.swift:14:4: warning: Todo Violation: TODOs should be avoided (fill this in!). (todo)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Account/FxAClient10.swift:526:69: warning: Todo Violation: TODOs should be avoided (debate key size and extract th…). (todo)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Client/Frontend/Browser/BrowserViewController/BrowserViewController+WKNavigationDelegate.swift:99:37: warning: Todo Violation: TODOs should be avoided (Is this the same as isWhitelis…). (todo)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Client/Frontend/Browser/OpenSearch.swift:249:12: warning: Todo Violation: TODOs should be avoided (For now, just use the largest …). (todo)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Client/Frontend/Browser/SearchLoader.swift:14:4: warning: Todo Violation: TODOs should be avoided (Swift currently requires that …). (todo)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Client/Frontend/Browser/SearchViewController.swift:20:8: warning: Todo Violation: TODOs should be avoided (This should use ToolbarHeight …). (todo)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Client/Frontend/Browser/Tab.swift:73:62: warning: Todo Violation: TODOs should be avoided (generalize this.). (todo)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Client/Frontend/ContentBlocker/ContentBlockerSettingViewController.swift:16:12: warning: Todo Violation: TODOs should be avoided (Get a dedicated string for thi…). (todo)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Client/Frontend/ContentBlocker/ContentBlockerHelper.swift:383:12: warning: Todo Violation: TODOs should be avoided (Not done). (todo)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Client/Frontend/Browser/BrowserViewController.swift:102:8: warning: Todo Violation: TODOs should be avoided (weak references?). (todo)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Client/Frontend/Browser/BrowserViewController.swift:1217:4: warning: Todo Violation: TODOs should be avoided (this should be expanded to tra…). (todo)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Client/Frontend/Browser/BrowserViewController.swift:1339:16: warning: Todo Violation: TODOs should be avoided (https://bugzilla.mozilla.org/s…). (todo)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Client/Frontend/Browser/BrowserViewController.swift:1706:42: warning: Todo Violation: TODOs should be avoided (UX Right now the flow for sign…). (todo)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Client/Frontend/Browser/BrowserViewController.swift:1710:42: warning: Todo Violation: TODOs should be avoided (UX Right now the flow for sign…). (todo)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Client/Frontend/Browser/BrowserViewController.swift:2251:81: warning: Todo Violation: TODOs should be avoided (Check result, can this fail?). (todo)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Client/Frontend/Browser/BrowserViewController.swift:2259:80: warning: Todo Violation: TODOs should be avoided (Check result, can this fail?). (todo)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Client/Frontend/Browser/BrowserViewController.swift:2268:141: warning: Todo Violation: TODOs should be avoided (Check result, can this fail?). (todo)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Client/Frontend/Browser/BrowserViewController.swift:2278:66: warning: Todo Violation: TODOs should be avoided (Check result, can this fail?). (todo)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Client/Frontend/Home/BookmarksPanel.swift:414:16: warning: Todo Violation: TODOs should be avoided (check whether the folder is em…). (todo)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Client/Frontend/Home/ReaderPanel.swift:118:113: warning: Todo Violation: TODOs should be avoided (Not clear from ux spec). (todo)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Client/Frontend/Home/ReaderPanel.swift:429:20: warning: Todo Violation: TODOs should be avoided (This is a bit odd because the …). (todo)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Client/Frontend/Home/RemoteTabsPanel.swift:24:71: warning: Todo Violation: TODOs should be avoided (I set this to 8 so that it all…). (todo)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Client/Frontend/Home/RemoteTabsPanel.swift:203:12: warning: Todo Violation: TODOs should be avoided (Bug 1144765 - Populate image w…). (todo)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Client/Frontend/Reader/ReadabilityService.swift:67:24: warning: Todo Violation: TODOs should be avoided (Fail). (todo)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Client/Frontend/Reader/ReadabilityService.swift:70:20: warning: Todo Violation: TODOs should be avoided (Not entitely sure what to do o…). (todo)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Client/Frontend/Reader/ReaderModeHandlers.swift:78:67: warning: Todo Violation: TODOs should be avoided (Needs a proper error page). (todo)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Client/Frontend/Reader/ReaderModeStyleViewController.swift:17:64: warning: Todo Violation: TODOs should be avoided (THis needs to be 44% of 0x3333…). (todo)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Client/Frontend/Reader/ReaderModeStyleViewController.swift:22:71: warning: Todo Violation: TODOs should be avoided (THis needs to be 44% of 0x3333…). (todo)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Client/Frontend/Reader/ReaderModeStyleViewController.swift:307:12: warning: Todo Violation: TODOs should be avoided (Does this need to change with …). (todo)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Client/Frontend/Reader/ReaderModeStyleViewController.swift:323:12: warning: Todo Violation: TODOs should be avoided. (todo)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Client/Frontend/Widgets/PhotonActionSheetProtocol.swift:75:6: warning: Todo Violation: TODOs should be avoided (These icons should all have th…). (todo)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Client/Frontend/Widgets/PhotonActionSheetProtocol.swift:139:15: warning: Todo Violation: TODOs should be avoided (can all this logic go somewher…). (todo)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Client/Frontend/Widgets/PhotonActionSheetProtocol.swift:156:15: warning: Todo Violation: TODOs should be avoided (can all this logic go somewher…). (todo)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Client/Frontend/Widgets/PhotonActionSheetProtocol.swift:270:16: warning: Todo Violation: TODOs should be avoided (Enable Tracking protection for…). (todo)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Client/Frontend/Widgets/TwoLineCell.swift:175:8: warning: Todo Violation: TODOs should be avoided (Not ideal. We should figure ou…). (todo)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Client/Helpers/UserActivityHandler.swift:25:56: warning: Todo Violation: TODOs should be avoided (Bug 1390294). (todo)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Client/Helpers/FxALoginHelper.swift:117:20: warning: Todo Violation: TODOs should be avoided (add UI to tell the user to go …). (todo)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Client/Helpers/FxALoginHelper.swift:335:12: warning: Todo Violation: TODOs should be avoided (fix Bug 1168690, to tell Sync …). (todo)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Extensions/SendTo/InstructionsViewController.swift:93:33: warning: Todo Violation: TODOs should be avoided (Not sure what to do or if to k…). (todo)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Extensions/SendTo/ClientPickerViewController.swift:312:32: warning: Todo Violation: TODOs should be avoided (We used to have a 'show me how…). (todo)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Extensions/ShareTo/InitialViewController.swift:17:73: warning: Todo Violation: TODOs should be avoided (Is the correct color documente…). (todo)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Extensions/ShareTo/InitialViewController.swift:82:8: warning: Todo Violation: TODOs should be avoided (use Set.). (todo)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Extensions/ShareTo/InitialViewController.swift:117:31: warning: Todo Violation: TODOs should be avoided (Why does UILayoutPriorityRequi…). (todo)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Extensions/ShareTo/ShareViewController.swift:15:4: warning: Todo Violation: TODOs should be avoided (See if we can do this with an …). (todo)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Extensions/ShareTo/ShareViewController.swift:105:47: warning: Todo Violation: TODOs should be avoided (Can go away if icon is provide…). (todo)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Extensions/ShareTo/ShareViewController.swift:168:12: warning: Todo Violation: TODOs should be avoided (See Bug 1102516 - Use Snappy t…). (todo)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Providers/NSUserDefaultsPrefs.swift:129:12: warning: Todo Violation: TODOs should be avoided (userDefaults.removePersistentD…). (todo)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Providers/SyncStatusResolver.swift:105:12: warning: Todo Violation: TODOs should be avoided (Instead of finding the worst o…). (todo)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/ReadingList/ReadingListError.swift:8:4: warning: Todo Violation: TODOs should be avoided (This needs to encapsulate an N…). (todo)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/ReadingList/ReadingListFetchSpec.swift:7:4: warning: Todo Violation: TODOs should be avoided (This should really use NSURLCo…). (todo)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/ReadingList/ReadingListRecord.swift:7:4: warning: Todo Violation: TODOs should be avoided (This is not used anymore. Deci…). (todo)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/ReadingList/ReadingListRecordResponse.swift:15:16: warning: Todo Violation: TODOs should be avoided (On Android we call super.wasSu…). (todo)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/ReadingList/ReadingListClient.swift:18:46: warning: Todo Violation: TODOs should be avoided (Should really call this NotMod…). (todo)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/ReadingList/ReadingListClient.swift:26:46: warning: Todo Violation: TODOs should be avoided (Should really call this NotMod…). (todo)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/ReadingList/ReadingListClient.swift:76:16: warning: Todo Violation: TODOs should be avoided (???). (todo)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/ReadingList/ReadingListClient.swift:101:16: warning: Todo Violation: TODOs should be avoided (???). (todo)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/ReadingList/ReadingListClient.swift:116:39: warning: Todo Violation: TODOs should be avoided (Should we have different resul…). (todo)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/ReadingList/ReadingListClient.swift:171:16: warning: Todo Violation: TODOs should be avoided (???). (todo)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/ReadingList/ReadingListClient.swift:198:18: warning: Todo Violation: TODOs should be avoided (Handle errors here). (todo)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/ReadingList/ReadingListRecordsResponse.swift:15:16: warning: Todo Violation: TODOs should be avoided (On Android we call super.wasSu…). (todo)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/ReadingList/ReadingListResponse.swift:9:5: warning: Todo Violation: TODOs should be avoided (In the Android code this is a …). (todo)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/ReadingList/ReadingListSynchronizer.swift:28:12: warning: Todo Violation: TODOs should be avoided (Check if we are already syncin…). (todo)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/ReadingList/ReadingListSynchronizer.swift:29:12: warning: Todo Violation: TODOs should be avoided (If this is a first time sync t…). (todo)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/ReadingList/ReadingListSynchronizer.swift:30:12: warning: Todo Violation: TODOs should be avoided (Check if the client is configu…). (todo)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/ReadingList/ReadingListSQLStorage.swift:39:45: warning: Todo Violation: TODOs should be avoided (Unique but may be null?). (todo)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Shared/Bytes.swift:45:11: warning: Todo Violation: TODOs should be avoided. (todo)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Providers/Profile.swift:1206:16: warning: Todo Violation: TODOs should be avoided (recognize .NotStarted.). (todo)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Providers/Profile.swift:1226:16: warning: Todo Violation: TODOs should be avoided (recognize .NotStarted.). (todo)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Shared/KeychainCache.swift:57:12: warning: Todo Violation: TODOs should be avoided (PII logging.). (todo)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Storage/Clients.swift:59:4: warning: Todo Violation: TODOs should be avoided (should this really compare tab…). (todo)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Storage/Bookmarks/Bookmarks.swift:17:8: warning: Todo Violation: TODOs should be avoided. (todo)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Storage/Bookmarks/Bookmarks.swift:137:8: warning: Todo Violation: TODOs should be avoided (We don't create outbound recor…). (todo)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Storage/Bookmarks/Bookmarks.swift:364:12: warning: Todo Violation: TODOs should be avoided (this should never be nil!). (todo)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Storage/History.swift:96:4: warning: Todo Violation: TODOs should be avoided (integrate Site with this.). (todo)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Storage/MockLogins.swift:88:12: warning: Todo Violation: TODOs should be avoided. (todo)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Storage/MockLogins.swift:93:12: warning: Todo Violation: TODOs should be avoided. (todo)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Storage/MockLogins.swift:98:12: warning: Todo Violation: TODOs should be avoided. (todo)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Storage/MockLogins.swift:142:8: warning: Todo Violation: TODOs should be avoided. (todo)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Storage/Site.swift:30:4: warning: Todo Violation: TODOs should be avoided (Site shouldn't have all of the…). (todo)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Storage/SQL/LoginsSchema.swift:41:8: warning: Todo Violation: TODOs should be avoided (transaction.). (todo)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Storage/SQL/LoginsSchema.swift:108:12: warning: Todo Violation: TODOs should be avoided (real update!). (todo)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Storage/Logins.swift:344:8: warning: Todo Violation: TODOs should be avoided (it's possible that we'll have,…). (todo)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Storage/SQL/BrowserSchema.swift:160:8: warning: Todo Violation: TODOs should be avoided (transaction.). (todo)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Storage/SQL/BrowserSchema.swift:498:8: warning: Todo Violation: TODOs should be avoided (phrase this without the subsel…). (todo)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Storage/SQL/BrowserSchema.swift:520:8: warning: Todo Violation: TODOs should be avoided (phrase this without the subsel…). (todo)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Storage/SQL/BrowserSchema.swift:949:16: warning: Todo Violation: TODOs should be avoided (trigger a sync?). (todo)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Storage/SQL/SQLiteBookmarksModel.swift:412:12: warning: Todo Violation: TODOs should be avoided (Yes, this can be done in one g…). (todo)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Storage/SQL/SQLiteBookmarksModel.swift:540:12: warning: Todo Violation: TODOs should be avoided (bump the parent's modified tim…). (todo)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Storage/SQL/SQLiteBookmarksModel.swift:588:12: warning: Todo Violation: TODOs should be avoided (share this logic with SQLiteHi…). (todo)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Storage/SQL/SQLiteBookmarksModel.swift:600:68: warning: Todo Violation: TODOs should be avoided. (todo)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Storage/SQL/SQLiteBookmarksModel.swift:692:12: warning: Todo Violation: TODOs should be avoided. (todo)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Storage/SQL/SQLiteBookmarksModel.swift:722:25: warning: Todo Violation: TODOs should be avoided. (todo)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Storage/SQL/SQLiteRemoteClientsAndTabs.swift:33:58: warning: Todo Violation: TODOs should be avoided (find a way to make this less d…). (todo)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Storage/SQL/SQLiteRemoteClientsAndTabs.swift:111:12: warning: Todo Violation: TODOs should be avoided (insert multiple clients in a s…). (todo)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Storage/SQL/SQLiteRemoteClientsAndTabs.swift:379:12: warning: Todo Violation: TODOs should be avoided (Bug 1168690 - delete our clien…). (todo)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Storage/SQL/SQLiteBookmarksSyncing.swift:202:12: warning: Todo Violation: TODOs should be avoided (these can be merged into a sin…). (todo)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Storage/SQL/SQLiteBookmarksSyncing.swift:392:45: warning: Todo Violation: TODOs should be avoided (batch the inserts!)). (todo)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Storage/SQL/SQLiteHistory.swift:82:8: warning: Todo Violation: TODOs should be avoided (this can probably be improved.). (todo)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Storage/SQL/SQLiteHistory.swift:213:13: warning: Todo Violation: TODOs should be avoided (remove the LEFT JOIN to fill i…). (todo)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Storage/SQL/SQLiteHistory.swift:316:12: warning: Todo Violation: TODOs should be avoided (make is_bookmarked here accura…). (todo)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Storage/SQL/SQLiteHistory.swift:317:12: warning: Todo Violation: TODOs should be avoided (ensure that the same URL doesn…). (todo)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Storage/SQL/SQLiteHistory.swift:506:8: warning: Todo Violation: TODOs should be avoided (thread siteID into this to avo…). (todo)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Storage/SQL/SQLiteHistory.swift:712:8: warning: Todo Violation: TODOs should be avoided. (todo)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Storage/SQL/SQLiteHistory.swift:800:74: warning: Todo Violation: TODOs should be avoided ()). (todo)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Storage/SQL/SQLiteLogins.swift:565:12: warning: Todo Violation: TODOs should be avoided (these steps can be done in a s…). (todo)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Storage/SQL/SQLiteLogins.swift:566:12: warning: Todo Violation: TODOs should be avoided (if there's no mirror record, a…). (todo)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Storage/SQL/SQLiteLogins.swift:719:58: warning: Todo Violation: TODOs should be avoided (proper host/port check after f…). (todo)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Storage/SQL/SQLiteLogins.swift:737:20: warning: Todo Violation: TODOs should be avoided (join against the mirror table …). (todo)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Storage/SQL/SQLiteLogins.swift:876:8: warning: Todo Violation: TODOs should be avoided (is this safe for a regular res…). (todo)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Storage/Visit.swift:118:8: warning: Todo Violation: TODOs should be avoided (compare Site.). (todo)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Sync/ClientPayload.swift:56:8: warning: Todo Violation: TODOs should be avoided (version, protocols.). (todo)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Sync/HistoryPayload.swift:28:57: warning: Todo Violation: TODOs should be avoided (validate URI.). (todo)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Sync/HistoryPayload.swift:75:16: warning: Todo Violation: TODOs should be avoided (compare visits.). (todo)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Sync/KeysPayload.swift:51:12: warning: Todo Violation: TODOs should be avoided (check collections.). (todo)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Sync/BookmarkPayload.swift:153:16: warning: Todo Violation: TODOs should be avoided (these might need to be weakene…). (todo)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Sync/BookmarkPayload.swift:206:16: warning: Todo Violation: TODOs should be avoided (these might need to be weakene…). (todo)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Sync/BookmarkPayload.swift:284:16: warning: Todo Violation: TODOs should be avoided (these might need to be weakene…). (todo)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Sync/BookmarkPayload.swift:340:12: warning: Todo Violation: TODOs should be avoided (compare optional fields.). (todo)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Sync/BookmarkPayload.swift:374:16: warning: Todo Violation: TODOs should be avoided (these might need to be weakene…). (todo)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Sync/LoginPayload.swift:151:16: warning: Todo Violation: TODOs should be avoided (optional fields.). (todo)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Sync/Record.swift:46:8: warning: Todo Violation: TODOs should be avoided (consider using error tuples.). (todo)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Sync/Record.swift:70:12: warning: Todo Violation: TODOs should be avoided (modified, sortindex, ttl). (todo)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Sync/KeyBundle.swift:169:8: warning: Todo Violation: TODOs should be avoided (how much do we want to move th…). (todo)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Sync/Synchronizers/Bookmarks/BookmarksDownloader.swift:75:8: warning: Todo Violation: TODOs should be avoided. (todo)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Sync/Synchronizers/Bookmarks/BookmarksDownloader.swift:79:8: warning: Todo Violation: TODOs should be avoided. (todo)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Sync/State.swift:191:4: warning: Todo Violation: TODOs should be avoided (the Scratchpad needs to be loa…). (todo)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Sync/State.swift:424:12: warning: Todo Violation: TODOs should be avoided (I think a new keyLabel is un…). (todo)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Sync/Synchronizers/Bookmarks/Merging.swift:15:8: warning: Todo Violation: TODOs should be avoided (this should probably return a …). (todo)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Sync/Synchronizers/Bookmarks/BookmarksSynchronizer.swift:441:12: warning: Todo Violation: TODOs should be avoided. (todo)
📖	This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Sync/Synchronizers/Bookmarks/BookmarksSynchronizer.swift:455:12: warning: Todo Violation: TODOs should be avoided. (todo)
⚠️	Danger found 2555 violations with this PR. Due to GitHub's max issue comment size, the number shown has been truncated to 144.

Generated by 🚫 Danger

[codecov-io]

Codecov Report

Merging #2069 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master    #2069   +/-   ##
=======================================
  Coverage   89.68%   89.68%           
=======================================
  Files         256      256           
  Lines       14907    14907           
  Branches      972      972           
=======================================
  Hits        13369    13369           
  Misses       1521     1521           
  Partials       17       17

Impacted Files	Coverage Δ
Tests/SwiftLintFrameworkTests/TodoRuleTests.swift	100% <100%> (ø)	⬆️
Source/SwiftLintFramework/Rules/TodoRule.swift	86.79% <100%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8be79c...9fff3d3. Read the comment docs.