Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds opt-in rule discouraged_optional_collection #2001

Merged
merged 15 commits into from
Mar 27, 2018
Merged

Adds opt-in rule discouraged_optional_collection #2001

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
faee8c9
Adds opt-in rule discouraged_optional_collection
ornithocoder Jan 10, 2018
6e1630e
Improves regular expression
ornithocoder Jan 10, 2018
86727ac
Adds extra example
ornithocoder Jan 10, 2018
190a39a
Uses AST instead of regular expressions
ornithocoder Jan 14, 2018
6056b3e
Moves examples to own file
ornithocoder Jan 15, 2018
16085d3
Returns the Range of the entire optional collection
ornithocoder Jan 15, 2018
53b0fff
Adds more examples
ornithocoder Jan 15, 2018
5c20114
Simplifies guard statements
ornithocoder Jan 16, 2018
67c085a
Updates changelog entry
ornithocoder Feb 16, 2018
ac149d2
Adds examples to String extension
ornithocoder Feb 17, 2018
dcdd50a
Fixes typo in documentation
ornithocoder Feb 17, 2018
15a521a
Adds mathematical intervals (w/ lower and upper bounds)
ornithocoder Feb 17, 2018
61e7997
Renames method
ornithocoder Feb 17, 2018
3e5f7c5
Simplifies guard logic
ornithocoder Feb 20, 2018
90d6399
Updates change log
ornithocoder Mar 14, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,13 @@
* Add `empty_string` opt-in rule to validate against comparing strings to `""`
instead of using `.isEmpty`.  
[Davide Sibilio](https://github.com/idevid)

* Add `untyped_error_in_catch` opt-in rule to warn against declaring errors
without an explicit type in catch statements instead of using the implicit
`error` variable.
[Daniel Metzing](https://github.com/dirtydanee)
[#2045](https://github.com/realm/SwiftLint/issues/2045)

* Add `all` keyword for use in disable / enable statement:
`// swiftlint:disable all`.
It allows disabling SwiftLint entirely, in-code, for a particular section.
Expand All @@ -33,6 +33,11 @@
[Ash Furrow](https://github.com/ashfurrow)
[#2051](https://github.com/realm/SwiftLint/issues/2051)

* Adds `discouraged_optional_collection` opt-in rule to encourage the use of
empty collections instead of optional collections.
[Ornithologist Coder](https://github.com/ornithocoder)
[#1885](https://github.com/realm/SwiftLint/issues/1885)

#### Bug Fixes

* Fix TODOs lint message to state that TODOs should be resolved instead of
Expand Down
Loading