Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sorted imports auto correction #1845

Closed

Conversation

sammy-SC
Copy link
Contributor

@sammy-SC sammy-SC commented Sep 17, 2017

Makes sorted_imports corractable.
Feature request: #1822

I was not sure how to handle this case.

import BBB
// comment 
import CCC
import AAA

the code above will generate warning from sorted_imports but autocorrection won't fix it because I am not sure what to do with the comment. The code above will result into following correction. Same thing happens if there is a code in place of the comment.

import BBB
// comment 
import AAA
import CCC

Any comments or suggestions are very welcome.

@SwiftLintBot
Copy link

SwiftLintBot commented Sep 17, 2017

326 Warnings
⚠️ This PR may need tests.
⚠️ This PR introduced a violation in Aerial: /Users/distiller/SwiftLint/osscheck/Aerial/Tests/PreferencesTests.swift:10:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/DataSources/ActivitiesDataSourceTests.swift:2:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/DataSources/ActivitiesDataSourceTests.swift:4:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/DataSources/BackerDashboardProjectsDataSourceTests.swift:2:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/DataSources/BackerDashboardProjectsDataSourceTests.swift:3:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/DataSources/CommentsDataSourceTests.swift:2:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/DataSources/CommentsDataSourceTests.swift:4:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/DataSources/DashboardDataSourceTests.swift:2:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/DataSources/DashboardDataSourceTests.swift:4:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/DataSources/DashboardProjectsDrawerDataSourceTests.swift:2:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/DataSources/DashboardProjectsDrawerDataSourceTests.swift:4:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/DataSources/DiscoveryFiltersDataSourceTests.swift:2:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/DataSources/DiscoveryProjectsDataSourceTest.swift:2:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/DataSources/DiscoveryProjectsDataSourceTest.swift:4:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/DataSources/DiscoveryPagesDataSourceTests.swift:2:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/DataSources/LiveStreamChatDataSourceTests.swift:2:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/DataSources/LiveStreamChatDataSourceTests.swift:4:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/DataSources/FindFriendsDataSourceTests.swift:2:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/DataSources/FindFriendsDataSourceTests.swift:3:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/DataSources/LiveStreamContainerPagesDataSourceTests.swift:2:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/DataSources/LiveStreamContainerPagesDataSourceTests.swift:5:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/DataSources/LiveStreamDiscoveryDataSourceTests.swift:3:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/DataSources/ProfileDataSourceTests.swift:2:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/DataSources/ProfileDataSourceTests.swift:4:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/DataSources/ProjectActivitiesDataSourceTests.swift:3:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/DataSources/ProjectActivitiesDataSourceTests.swift:4:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/DataSources/SearchDataSourceTests.swift:2:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/DataSources/SearchDataSourceTests.swift:4:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/DataSources/ProjectPamphletContentDataSourceTests.swift:2:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/DataSources/ProjectPamphletContentDataSourceTests.swift:5:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/DataSources/ThanksProjectsDataSourceTests.swift:2:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/DataSources/ThanksProjectsDataSourceTests.swift:4:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/ViewModels/HelpWebViewModelTests.swift:2:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/ViewModels/RootViewModelTests.swift:3:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/ViewModels/RootViewModelTests.swift:5:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/ViewModels/UpdatePreviewViewModelTests.swift:3:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/ViewModels/UpdateViewModelTests.swift:3:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/ViewModels/AppDelegateViewModelTests.swift:9:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/ViewModels/AppDelegateViewModelTests.swift:11:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/Views/Controllers/BackerDashboardProjectsViewControllerTests.swift:4:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/Views/Controllers/CommentsViewControllerTests.swift:5:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/Views/Controllers/BackingViewControllerTests.swift:5:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/Views/Controllers/DashboardViewControllerTests.swift:2:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/Views/Controllers/DiscoveryPageViewControllerTests.swift:4:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/Views/Controllers/FacebookConfirmationViewControllerTests.swift:2:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/Views/Controllers/FindFriendsViewControllerTests.swift:2:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/Views/Controllers/LiveStreamCountdownViewControllerTests.swift:2:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/Views/Controllers/LiveStreamContainerViewControllerTests.swift:3:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/Views/Controllers/LoginToutViewControllerTests.swift:2:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/Views/Controllers/LoginViewControllerTests.swift:2:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/Views/Controllers/MessageThreadsViewControllerTests.swift:5:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/Views/Controllers/ProfileViewControllerTests.swift:4:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/Views/Controllers/ProjectActivityViewControllerTests.swift:5:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/Views/Controllers/ProjectNavBarViewControllerTests.swift:5:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/Views/Controllers/ResetPasswordViewControllerTests.swift:2:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/Views/Controllers/ProjectPamphletContentViewControllerTests.swift:5:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/Views/Controllers/RewardPledgeViewControllerTests.swift:6:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/Views/Controllers/SearchViewControllerTests.swift:5:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/Views/Controllers/SettingsViewControllerTests.swift:5:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/Views/Controllers/SignupViewControllerTests.swift:2:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/Views/Controllers/TwoFactorViewControllerTests.swift:5:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/Views/FundingGraphViewTests.swift:6:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/Views/LiveStreamNavTitleViewTests.swift:4:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/KsApi/lib/EncodableTests.swift:2:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/KsApi/models/ActivityTests.swift:2:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/KsApi/models/BackingTests.swift:2:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/KsApi/models/CategoryTests.swift:2:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/KsApi/models/ChangePaymentMethodEnvelopeTests.swift:2:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/KsApi/models/CheckoutEnvelopeTests.swift:2:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/KsApi/models/CheckoutEnvelopeTests.swift:3:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/KsApi/models/CommentTests.swift:2:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/KsApi/models/CreatePledgeEnvelopeTests.swift:2:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/KsApi/models/ConfigTests.swift:2:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/KsApi/models/ErrorEnvelopeTests.swift:2:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/KsApi/models/ErrorEnvelopeTests.swift:3:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/KsApi/models/DiscoveryParamsTests.swift:4:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/KsApi/models/FindFriendsEnvelopeTests.swift:2:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/KsApi/models/FriendStatsEnvelopeTests.swift:2:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/KsApi/models/FriendStatsEnvelopeTests.swift:3:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/KsApi/models/ItemTests.swift:3:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/KsApi/models/LocationTests.swift:2:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/KsApi/models/MessageTests.swift:2:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/KsApi/models/MessageThreadTests.swift:2:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/KsApi/models/Project.PhotoTests.swift:2:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/KsApi/models/Project.CountryTests.swift:2:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/KsApi/models/Project.VideoTests.swift:2:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/KsApi/models/ProjectStatsEnvelopeTests.swift:2:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/KsApi/models/ProjectStatsEnvelopeTests.swift:3:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/KsApi/models/ProjectTests.swift:2:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/KsApi/models/PushEnvelopeTests.swift:2:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/KsApi/models/RewardsItemTests.swift:3:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/KsApi/models/RewardTests.swift:2:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/KsApi/models/SubmitApplePayEnvelopeTests.swift:2:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/KsApi/models/UpdateDraftTests.swift:2:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/KsApi/models/UpdatePledgeEnvelopeTests.swift:2:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/KsApi/models/User.AvatarTests.swift:2:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/KsApi/models/UpdateTests.swift:2:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/KsApi/models/User.NewsletterSubscriptionsTests.swift:2:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/KsApi/models/UserTests.swift:2:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/KsApi/models/User.NotificationsTests.swift:2:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/KsApi/ServiceTests.swift:2:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/KsApi/ServiceTypeTests.swift:3:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Library/AppEnvironmentTests.swift:5:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Library/CircleAvatarImageViewTests.swift:2:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Library/EnvironmentTests.swift:2:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Library/DataSource/ValueCellDataSourceTests.swift:2:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Library/KSCacheTests.swift:2:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Library/LanguageTests.swift:2:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Library/LaunchedCountriesTests.swift:2:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Library/LiveStreamActivityItemProvider.swift:4:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Library/LocalizedStringTests.swift:2:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Library/Koala/KoalaTests.swift:5:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Library/NavigationTests.swift:5:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Library/PKPaymentRequestTests.swift:6:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Library/RefTagTests.swift:2:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Library/PaginateTests.swift:2:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Library/PaginateTests.swift:6:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Library/SharedFunctionsTests.swift:4:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Library/String+TruncateTests.swift:2:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Library/String+WhitespaceTests.swift:2:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Library/String+SimpleHTMLTests.swift:2:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Library/TestHelpers/TestCase.swift:8:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Library/TestHelpers/XCTestCase+AppEnvironment.swift:2:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Library/UIColorTests.swift:2:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Library/UILabel+IBClearTests.swift:2:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Library/UILabel+SimpleHTMLTests.swift:2:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Library/ViewModels/ActivityFriendBackingViewModelTests.swift:2:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Library/ViewModels/ActivityFriendBackingViewModelTests.swift:4:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Library/ViewModels/ActivityFriendFollowCellViewModelTests.swift:4:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
⚠️ Danger found 326 violations with this PR. Due to GitHub's max issue comment size, the number shown has been truncated to 130.
369 Messages
📖 Linting Aerial with this PR took 0.41s vs 0.38s on master (7% slower)
📖 Linting Alamofire with this PR took 3.07s vs 2.91s on master (5% slower)
📖 Linting Firefox with this PR took 12.79s vs 12.1s on master (5% slower)
📖 Linting Kickstarter with this PR took 19.33s vs 18.64s on master (3% slower)
📖 Linting Moya with this PR took 1.44s vs 1.35s on master (6% slower)
📖 Linting Nimble with this PR took 1.9s vs 1.66s on master (14% slower)
📖 Linting Quick with this PR took 0.54s vs 0.52s on master (3% slower)
📖 Linting Realm with this PR took 2.74s vs 2.69s on master (1% slower)
📖 Linting SourceKitten with this PR took 0.97s vs 0.95s on master (2% slower)
📖 Linting Sourcery with this PR took 4.2s vs 4.13s on master (1% slower)
📖 Linting Swift with this PR took 13.48s vs 13.31s on master (1% slower)
📖 Linting WordPress with this PR took 11.37s vs 11.18s on master (1% slower)
📖 This PR fixed a violation in Aerial: /Users/distiller/SwiftLint/osscheck/Aerial/Tests/PreferencesTests.swift:10:18: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
📖 This PR fixed a violation in Alamofire: /Users/distiller/SwiftLint/osscheck/Alamofire/Source/MultipartFormData.swift:30:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
📖 This PR fixed a violation in Firefox: /Users/distiller/SwiftLint/osscheck/Firefox/Client/Application/QuickActions.swift:8:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
📖 This PR fixed a violation in Firefox: /Users/distiller/SwiftLint/osscheck/Firefox/Client/Frontend/Browser/OpenInHelper.swift:10:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
📖 This PR fixed a violation in Firefox: /Users/distiller/SwiftLint/osscheck/Firefox/Client/Frontend/Home/HistoryPanel.swift:7:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
📖 This PR fixed a violation in Firefox: /Users/distiller/SwiftLint/osscheck/Firefox/Client/Frontend/Home/RecentlyClosedTabsPanel.swift:7:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/DataSources/ActivitiesDataSourceTests.swift:2:18: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/DataSources/ActivitiesDataSourceTests.swift:4:18: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/DataSources/BackerDashboardProjectsDataSourceTests.swift:2:18: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/DataSources/BackerDashboardProjectsDataSourceTests.swift:3:18: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/DataSources/CommentsDataSourceTests.swift:2:18: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/DataSources/CommentsDataSourceTests.swift:4:18: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/DataSources/DashboardDataSourceTests.swift:2:18: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/DataSources/DashboardDataSourceTests.swift:4:18: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/DataSources/DashboardProjectsDrawerDataSourceTests.swift:2:18: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/DataSources/DashboardProjectsDrawerDataSourceTests.swift:4:18: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/AppDelegate.swift:9:8: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/DataSources/DiscoveryPagesDataSourceTests.swift:2:18: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/DataSources/DiscoveryProjectsDataSourceTest.swift:2:18: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/DataSources/DiscoveryProjectsDataSourceTest.swift:4:18: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/DataSources/DiscoveryFiltersDataSourceTests.swift:2:18: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/DataSources/LiveStreamChatDataSourceTests.swift:2:18: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/DataSources/LiveStreamChatDataSourceTests.swift:4:18: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/DataSources/FindFriendsDataSourceTests.swift:2:18: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/DataSources/FindFriendsDataSourceTests.swift:3:18: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/DataSources/LiveStreamContainerPagesDataSourceTests.swift:2:18: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/DataSources/LiveStreamContainerPagesDataSourceTests.swift:5:18: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/DataSources/LiveStreamDiscoveryDataSourceTests.swift:3:18: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/DataSources/ProfileDataSourceTests.swift:2:18: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/DataSources/ProfileDataSourceTests.swift:4:18: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/DataSources/ProjectActivitiesDataSourceTests.swift:3:18: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/DataSources/ProjectActivitiesDataSourceTests.swift:4:18: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/DataSources/SearchDataSourceTests.swift:2:18: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/DataSources/SearchDataSourceTests.swift:4:18: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/DataSources/ProjectPamphletContentDataSourceTests.swift:2:18: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/DataSources/ProjectPamphletContentDataSourceTests.swift:5:18: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/DataSources/ThanksProjectsDataSourceTests.swift:2:18: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/DataSources/ThanksProjectsDataSourceTests.swift:4:18: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/ViewModels/HelpWebViewModelTests.swift:2:18: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/ViewModels/RootViewModelTests.swift:3:18: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/ViewModels/RootViewModelTests.swift:5:18: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/ViewModels/UpdatePreviewViewModelTests.swift:3:18: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/ViewModels/UpdateViewModelTests.swift:3:18: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/ViewModels/AppDelegateViewModelTests.swift:9:18: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/ViewModels/AppDelegateViewModelTests.swift:11:18: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/Views/Controllers/BackerDashboardProjectsViewControllerTests.swift:4:18: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/Views/Controllers/CommentsViewControllerTests.swift:5:18: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/Views/Controllers/BackingViewControllerTests.swift:5:18: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/Views/Controllers/DashboardViewControllerTests.swift:2:18: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/Views/Controllers/DiscoveryPageViewControllerTests.swift:4:18: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/Views/Controllers/FacebookConfirmationViewControllerTests.swift:2:18: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/Views/Controllers/FindFriendsViewControllerTests.swift:2:18: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/Views/Controllers/LiveStreamCountdownViewControllerTests.swift:2:18: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/Views/Controllers/LiveStreamContainerViewControllerTests.swift:3:18: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/Views/Controllers/LoginToutViewControllerTests.swift:2:18: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/Views/Controllers/LoginViewControllerTests.swift:2:18: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/Views/Controllers/MessageThreadsViewControllerTests.swift:5:18: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/Views/Controllers/ProfileViewControllerTests.swift:4:18: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/Views/Controllers/ProjectActivityViewControllerTests.swift:5:18: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/Views/Controllers/ProjectNavBarViewControllerTests.swift:5:18: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/Views/Controllers/ResetPasswordViewControllerTests.swift:2:18: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/Views/Controllers/ProjectPamphletContentViewControllerTests.swift:5:18: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/Views/Controllers/RewardPledgeViewControllerTests.swift:6:18: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/Views/Controllers/SearchViewControllerTests.swift:5:18: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/Views/Controllers/SettingsViewControllerTests.swift:5:18: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/Views/Controllers/SignupViewControllerTests.swift:2:18: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/Views/Controllers/TwoFactorViewControllerTests.swift:5:18: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/Views/FundingGraphViewTests.swift:6:18: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/Views/LiveStreamNavTitleViewTests.swift:4:18: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/KsApi/lib/EncodableTests.swift:2:18: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/KsApi/models/ActivityTests.swift:2:18: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/KsApi/models/BackingTests.swift:2:18: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/KsApi/models/CategoryTests.swift:2:18: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/KsApi/models/ChangePaymentMethodEnvelopeTests.swift:2:18: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/KsApi/models/CheckoutEnvelopeTests.swift:2:18: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/KsApi/models/CheckoutEnvelopeTests.swift:3:18: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/KsApi/models/CommentTests.swift:2:18: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/KsApi/models/CreatePledgeEnvelopeTests.swift:2:18: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/KsApi/models/ConfigTests.swift:2:18: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/KsApi/models/ErrorEnvelopeTests.swift:2:18: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/KsApi/models/ErrorEnvelopeTests.swift:3:18: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/KsApi/models/DiscoveryParamsTests.swift:4:18: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/KsApi/models/FindFriendsEnvelopeTests.swift:2:18: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/KsApi/models/FriendStatsEnvelopeTests.swift:2:18: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/KsApi/models/FriendStatsEnvelopeTests.swift:3:18: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/KsApi/models/ItemTests.swift:3:18: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/KsApi/models/LocationTests.swift:2:18: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/KsApi/models/MessageTests.swift:2:18: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/KsApi/models/MessageThreadTests.swift:2:18: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/KsApi/models/Project.PhotoTests.swift:2:18: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/KsApi/models/Project.CountryTests.swift:2:18: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/KsApi/models/Project.VideoTests.swift:2:18: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/KsApi/models/ProjectStatsEnvelopeTests.swift:2:18: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/KsApi/models/ProjectStatsEnvelopeTests.swift:3:18: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/KsApi/models/ProjectTests.swift:2:18: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/KsApi/models/PushEnvelopeTests.swift:2:18: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/KsApi/models/RewardsItemTests.swift:3:18: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/KsApi/models/RewardTests.swift:2:18: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/KsApi/models/SubmitApplePayEnvelopeTests.swift:2:18: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/KsApi/models/UpdateDraftTests.swift:2:18: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/KsApi/models/User.AvatarTests.swift:2:18: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/KsApi/models/UpdatePledgeEnvelopeTests.swift:2:18: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/KsApi/models/UpdateTests.swift:2:18: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/KsApi/models/User.NewsletterSubscriptionsTests.swift:2:18: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/KsApi/models/User.NotificationsTests.swift:2:18: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/KsApi/models/UserTests.swift:2:18: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/KsApi/ServiceTests.swift:2:18: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/KsApi/ServiceTypeTests.swift:3:18: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Library/AppEnvironmentTests.swift:5:18: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Library/CircleAvatarImageViewTests.swift:2:18: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Library/EnvironmentTests.swift:2:18: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Library/DataSource/ValueCellDataSourceTests.swift:2:18: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Library/KSCacheTests.swift:2:18: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Library/LanguageTests.swift:2:18: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Library/LaunchedCountriesTests.swift:2:18: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Library/LiveStreamActivityItemProvider.swift:4:10: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Library/LocalizedStringTests.swift:2:18: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Library/Koala/KoalaTests.swift:5:18: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Library/NavigationTests.swift:5:18: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Library/PKPaymentRequestTests.swift:6:18: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Library/RefTagTests.swift:2:18: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Library/PaginateTests.swift:2:18: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Library/PaginateTests.swift:6:18: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Library/SharedFunctionsTests.swift:4:18: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Library/String+TruncateTests.swift:2:18: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Library/String+WhitespaceTests.swift:2:18: warning: Sorted Imports Violation: Imports should be sorted. (sorted_imports)
⚠️ Danger found 369 violations with this PR. Due to GitHub's max issue comment size, the number shown has been truncated to 138.

Generated by 🚫 Danger

@sammy-SC sammy-SC force-pushed the sorted_imports-auto-correction branch from db1fca5 to 6d59025 Compare September 17, 2017 11:20
@jpsim
Copy link
Collaborator

jpsim commented Sep 17, 2017

I know @sberrevoets cares about this, so maybe he'd like to help review?

@sberrevoets
Copy link

sberrevoets commented Sep 18, 2017

@sammy-SC I think your approach is the right one. There will likely be edge cases, but sorting imports inside an import group (where a group spans from the first line that starts with import until a line does not start with import) seems to most straightforward.

That would cover your case, but also something like this:

import ABC
#if os(iOS)
import UIKit
#elseif os(macOS)
import AppKit
#endif

In that case everything for os(iOS) would be sorted separately from everything for os(macOS). Anything more complex than that is probably not worth autocorrecting because this can very complicated.

Warning should probably work the same way. If we introduce this concept of "import groups", the warning triggers can use that as well as I think a comment in the middle of a list of imports should be acceptable.

@sammy-SC sammy-SC force-pushed the sorted_imports-auto-correction branch from 6d59025 to 3695abe Compare September 18, 2017 20:54
@sammy-SC
Copy link
Contributor Author

@sberrevoets I agree that warning should work the same way.

I think it should be done in different pull request thought.

I will be happy to change the current implementation, please let me know whether I should do it in this PR or a different one. cc @jpsim

@sammy-SC sammy-SC force-pushed the sorted_imports-auto-correction branch from 5853fed to 3695abe Compare September 19, 2017 19:12
@sammy-SC sammy-SC force-pushed the sorted_imports-auto-correction branch from 3695abe to 90256f8 Compare September 19, 2017 19:18
@sberrevoets
Copy link

If you create an abstraction here that the warning implementation would benefit from, then I think it's OK to do here, but I'll let @jpsim make the final call on that.

@codecov-io
Copy link

codecov-io commented Sep 20, 2017

Codecov Report

Merging #1845 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1845      +/-   ##
==========================================
+ Coverage   88.89%   88.94%   +0.04%     
==========================================
  Files         236      236              
  Lines       11511    11560      +49     
==========================================
+ Hits        10233    10282      +49     
  Misses       1278     1278
Impacted Files Coverage Δ
...e/SwiftLintFramework/Rules/SortedImportsRule.swift 100% <100%> (ø) ⬆️
...ftLintFramework/Rules/VerticalWhitespaceRule.swift 95.69% <0%> (+0.04%) ⬆️
...wiftLintFramework/Rules/ControlStatementRule.swift 94.11% <0%> (+0.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb9acae...2bebf20. Read the comment docs.

@sammy-SC
Copy link
Contributor Author

@sberrevoets @jpsim I took the liberty and changed it here.
If you want me to open another PR to make that change I can cherry-pick the code without a problem.

@rastersize
Copy link

rastersize commented Oct 12, 2017

@sammy-SC @jpsim Any chance we can get this merged? I just manually correct this in a medium sized project, took a while 😸

And thank you!

@marcelofabri
Copy link
Collaborator

Closing in favor of #1922

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants