Fix false negatives in unneeded_parentheses_in_closure_argument with capture lists

[marcelofabri]

Fix #1817

[SwiftLintBot]

	63 Warnings
⚠️	This PR may need tests.
⚠️	This PR introduced a violation in Firefox: /Users/distiller/SwiftLint/osscheck/Firefox/Client/Frontend/Browser/BackForwardTableViewCell.swift:52:80: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/SwiftLint/osscheck/Firefox/Client/Frontend/Home/ActivityStreamTopSitesCell.swift:167:73: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/SwiftLint/osscheck/Firefox/Client/Frontend/Home/ReaderPanel.swift:403:123: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Firefox: /Users/distiller/SwiftLint/osscheck/Firefox/Client/Frontend/Widgets/ActivityStreamHighlightCell.swift:155:86: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/Views/Controllers/DashboardViewController.swift:78:36: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/Views/Controllers/DashboardViewController.swift:85:36: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/Views/Controllers/DiscoveryNavigationHeaderViewController.swift:65:36: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/Views/Controllers/DiscoveryNavigationHeaderViewController.swift:74:36: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/Views/Controllers/FindFriendsViewController.swift:49:36: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/Views/Controllers/FindFriendsViewController.swift:56:36: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/Views/Controllers/FindFriendsViewController.swift:63:36: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/Views/Controllers/LoginViewController.swift:124:36: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/Views/Controllers/LoginToutViewController.swift:123:36: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/Views/Controllers/SortPagerViewController.swift:83:36: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Kickstarter-iOS/Views/Controllers/SettingsViewController.swift:342:36: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in WordPress: /Users/distiller/SwiftLint/osscheck/WordPress/WordPress/Classes/Extensions/FLAnimatedImageView+Cache.swift:17:71: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in WordPress: /Users/distiller/SwiftLint/osscheck/WordPress/WordPress/Classes/Extensions/FLAnimatedImageView+Cache.swift:52:87: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in WordPress: /Users/distiller/SwiftLint/osscheck/WordPress/WordPress/Classes/ViewRelated/Blog/SiteIconPickerPresenter.swift:137:58: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in WordPress: /Users/distiller/SwiftLint/osscheck/WordPress/WordPress/Classes/ViewRelated/Blog/SiteIconPickerPresenter.swift:150:67: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in WordPress: /Users/distiller/SwiftLint/osscheck/WordPress/WordPress/Classes/ViewRelated/Blog/SharingButtonsViewController.swift:699:53: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in WordPress: /Users/distiller/SwiftLint/osscheck/WordPress/WordPress/Classes/ViewRelated/Blog/SharingButtonsViewController.swift:733:55: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in WordPress: /Users/distiller/SwiftLint/osscheck/WordPress/WordPress/Classes/ViewRelated/Blog/SharingButtonsViewController.swift:758:53: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in WordPress: /Users/distiller/SwiftLint/osscheck/WordPress/WordPress/Classes/ViewRelated/Me/AppSettingsViewController.swift:240:75: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in WordPress: /Users/distiller/SwiftLint/osscheck/WordPress/WordPress/Classes/ViewRelated/Me/AppSettingsViewController.swift:249:39: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in WordPress: /Users/distiller/SwiftLint/osscheck/WordPress/WordPress/Classes/ViewRelated/Notifications/Views/NoteTableViewCell.swift:95:114: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in WordPress: /Users/distiller/SwiftLint/osscheck/WordPress/WordPress/Classes/ViewRelated/NUX/LoginEmailViewController.swift:193:65: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in WordPress: /Users/distiller/SwiftLint/osscheck/WordPress/WordPress/Classes/ViewRelated/NUX/LoginEmailViewController.swift:328:117: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in WordPress: /Users/distiller/SwiftLint/osscheck/WordPress/WordPress/Classes/ViewRelated/NUX/LoginSiteAddressViewController.swift:144:84: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in WordPress: /Users/distiller/SwiftLint/osscheck/WordPress/WordPress/Classes/ViewRelated/NUX/LoginSiteAddressViewController.swift:150:35: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in WordPress: /Users/distiller/SwiftLint/osscheck/WordPress/WordPress/Classes/ViewRelated/NUX/LoginSiteAddressViewController.swift:186:83: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in WordPress: /Users/distiller/SwiftLint/osscheck/WordPress/WordPress/Classes/ViewRelated/NUX/LoginSiteAddressViewController.swift:189:39: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in WordPress: /Users/distiller/SwiftLint/osscheck/WordPress/WordPress/Classes/ViewRelated/NUX/LoginSelfHostedViewController.swift:276:65: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in WordPress: /Users/distiller/SwiftLint/osscheck/WordPress/WordPress/Classes/ViewRelated/NUX/LoginSelfHostedViewController.swift:289:60: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in WordPress: /Users/distiller/SwiftLint/osscheck/WordPress/WordPress/Classes/ViewRelated/NUX/LoginSelfHostedViewController.swift:318:120: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in WordPress: /Users/distiller/SwiftLint/osscheck/WordPress/WordPress/Classes/ViewRelated/NUX/LoginWPComViewController.swift:171:117: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in WordPress: /Users/distiller/SwiftLint/osscheck/WordPress/WordPress/Classes/ViewRelated/Pages/PageListViewController.swift:366:67: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in WordPress: /Users/distiller/SwiftLint/osscheck/WordPress/WordPress/Classes/ViewRelated/Pages/PageListViewController.swift:416:108: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in WordPress: /Users/distiller/SwiftLint/osscheck/WordPress/WordPress/Classes/ViewRelated/Pages/PageListViewController.swift:425:106: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in WordPress: /Users/distiller/SwiftLint/osscheck/WordPress/WordPress/Classes/ViewRelated/Pages/PageListViewController.swift:434:107: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in WordPress: /Users/distiller/SwiftLint/osscheck/WordPress/WordPress/Classes/ViewRelated/Pages/PageListViewController.swift:443:105: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in WordPress: /Users/distiller/SwiftLint/osscheck/WordPress/WordPress/Classes/ViewRelated/Pages/PageListViewController.swift:452:106: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in WordPress: /Users/distiller/SwiftLint/osscheck/WordPress/WordPress/Classes/ViewRelated/Pages/PageListViewController.swift:461:106: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in WordPress: /Users/distiller/SwiftLint/osscheck/WordPress/WordPress/Classes/ViewRelated/Pages/PageListViewController.swift:470:105: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in WordPress: /Users/distiller/SwiftLint/osscheck/WordPress/WordPress/Classes/ViewRelated/Pages/PageListViewController.swift:479:108: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in WordPress: /Users/distiller/SwiftLint/osscheck/WordPress/WordPress/Classes/ViewRelated/Pages/PageListViewController.swift:488:106: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in WordPress: /Users/distiller/SwiftLint/osscheck/WordPress/WordPress/Classes/ViewRelated/Aztec/ViewControllers/AztecPostViewController.swift:2492:105: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in WordPress: /Users/distiller/SwiftLint/osscheck/WordPress/WordPress/Classes/ViewRelated/Aztec/ViewControllers/AztecPostViewController.swift:2500:37: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in WordPress: /Users/distiller/SwiftLint/osscheck/WordPress/WordPress/Classes/ViewRelated/Aztec/ViewControllers/AztecPostViewController.swift:2523:105: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in WordPress: /Users/distiller/SwiftLint/osscheck/WordPress/WordPress/Classes/ViewRelated/Aztec/ViewControllers/AztecPostViewController.swift:2531:37: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in WordPress: /Users/distiller/SwiftLint/osscheck/WordPress/WordPress/Classes/ViewRelated/Aztec/ViewControllers/AztecPostViewController.swift:2614:37: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in WordPress: /Users/distiller/SwiftLint/osscheck/WordPress/WordPress/Classes/ViewRelated/Aztec/ViewControllers/AztecPostViewController.swift:2847:45: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in WordPress: /Users/distiller/SwiftLint/osscheck/WordPress/WordPress/Classes/ViewRelated/Aztec/ViewControllers/AztecPostViewController.swift:3023:89: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in WordPress: /Users/distiller/SwiftLint/osscheck/WordPress/WordPress/Classes/ViewRelated/Aztec/ViewControllers/AztecPostViewController.swift:3030:25: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in WordPress: /Users/distiller/SwiftLint/osscheck/WordPress/WordPress/Classes/ViewRelated/People/PeopleViewController.swift:250:40: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in WordPress: /Users/distiller/SwiftLint/osscheck/WordPress/WordPress/Classes/ViewRelated/People/PeopleViewController.swift:265:57: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in WordPress: /Users/distiller/SwiftLint/osscheck/WordPress/WordPress/Classes/ViewRelated/Post/AbstractPostListViewController.swift:787:39: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in WordPress: /Users/distiller/SwiftLint/osscheck/WordPress/WordPress/Classes/ViewRelated/Post/AbstractPostListViewController.swift:861:66: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in WordPress: /Users/distiller/SwiftLint/osscheck/WordPress/WordPress/Classes/ViewRelated/Post/AbstractPostListViewController.swift:924:26: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in WordPress: /Users/distiller/SwiftLint/osscheck/WordPress/WordPress/Classes/ViewRelated/Reader/ReaderFollowedSitesViewController.swift:159:35: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in WordPress: /Users/distiller/SwiftLint/osscheck/WordPress/WordPress/Classes/ViewRelated/Reader/ReaderFollowedSitesViewController.swift:189:35: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in WordPress: /Users/distiller/SwiftLint/osscheck/WordPress/WordPress/Classes/ViewRelated/Reader/ReaderFollowedSitesViewController.swift:216:35: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in WordPress: /Users/distiller/SwiftLint/osscheck/WordPress/WordPress/Classes/ViewRelated/Reader/ReaderMenuViewController.swift:244:39: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)

	12 Messages
📖	Linting Aerial with this PR took 0.4s vs 0.38s on master (5% slower)
📖	Linting Alamofire with this PR took 2.81s vs 2.88s on master (2% faster)
📖	Linting Firefox with this PR took 12.22s vs 12.15s on master (0% slower)
📖	Linting Kickstarter with this PR took 18.22s vs 18.07s on master (0% slower)
📖	Linting Moya with this PR took 1.34s vs 1.33s on master (0% slower)
📖	Linting Nimble with this PR took 1.62s vs 1.61s on master (0% slower)
📖	Linting Quick with this PR took 0.51s vs 0.51s on master (0% slower)
📖	Linting Realm with this PR took 2.63s vs 2.66s on master (1% faster)
📖	Linting SourceKitten with this PR took 0.93s vs 0.93s on master (0% slower)
📖	Linting Sourcery with this PR took 4.09s vs 4.06s on master (0% slower)
📖	Linting Swift with this PR took 12.99s vs 12.82s on master (1% slower)
📖	Linting WordPress with this PR took 10.9s vs 11.01s on master (0% faster)

Generated by 🚫 Danger

[codecov-io]

Codecov Report

❗ No coverage uploaded for pull request base (master@d0497fa). Click here to learn what that means.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master    #1827   +/-   ##
=========================================
  Coverage          ?   88.81%           
=========================================
  Files             ?      229           
  Lines             ?    11264           
  Branches          ?        0           
=========================================
  Hits              ?    10004           
  Misses            ?     1260           
  Partials          ?        0

Impacted Files	Coverage Δ
...les/UnneededParenthesesInClosureArgumentRule.swift	95.65% <100%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0497fa...fb3c3b2. Read the comment docs.