Support non Swift files in --file argument
#1755
Conversation
Generated by 🚫 Danger |
marcelofabri
force-pushed
the
mf-lint-non-swift-file
branch
from
542f91e to
bc00097
Compare
Codecov Report
@@ Coverage Diff @@
## master #1755 +/- ##
=========================================
+ Coverage 87.78% 87.8% +0.02%
=========================================
Files 219 219
Lines 10730 10730
=========================================
+ Hits 9419 9422 +3
+ Misses 1311 1308 -3
Continue to review full report at Codecov.
|
| @@ -21,7 +21,7 @@ extension FileManager: LintableFileManager { | |||
| .standardizingPath | |||
|
|
|||
| // if path is a file, it won't be returned in `enumerator(atPath:)` | |||
| if absolutePath.bridge().isSwiftFile() && absolutePath.isFile { | |||
| if absolutePath.isFile { | |||
There was a problem hiding this comment.
why this change? I think the lintablePaths change is sufficient to support the lint --path file.notswift scenario.
There was a problem hiding this comment.
I guess that's true, but when exactly would this check be true then? 🤔
There was a problem hiding this comment.
when specifying included and excluded configuration values, which IMO doesn't really make sense to specify non-Swift files in there.
There was a problem hiding this comment.
I'm kinda worried that if we extend included/excluded to support globbing, this change would attempt to lint non-Swift files if Sources/** were specified, for example.
There was a problem hiding this comment.
I've removed it 👍
marcelofabri
force-pushed
the
mf-lint-non-swift-file
branch
from
bc00097 to
a300409
Compare
Fixes #1721.