Fixed Readme custom rule included/excluded regexp #1729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -315,8 +315,8 @@ following syntax: | |||
| ```yaml | |||
| custom_rules: | |||
| pirates_beat_ninjas: # rule identifier | |||
| included: ".*.swift" # regex that defines paths to include during linting. optional. | |||
| excluded: ".*Test.swift" # regex that defines paths to exclude during linting. optional | |||
| included: ".*\\.swift" # regex that defines paths to include during linting. optional. | |||
There was a problem hiding this comment.
shouldn't it be just one backslash?
There was a problem hiding this comment.
One backslash would lead to a crash of yaml parser, so it has to be escaped.
Codecov Report
@@ Coverage Diff @@
## master #1729 +/- ##
=======================================
Coverage 87.43% 87.43%
=======================================
Files 209 209
Lines 10335 10335
=======================================
Hits 9036 9036
Misses 1299 1299Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, it does not check for dot presence, but for any symbol, so for example, if a filename is
MySuperFileswiftit would also work for this regexp. Same for excluded.