Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add block_based_kvo rule #1717

Merged
merged 1 commit into from
Jul 29, 2017
Merged

Add block_based_kvo rule #1717

merged 1 commit into from
Jul 29, 2017

Conversation

marcelofabri
Copy link
Collaborator

Fixes #1714.

In theory, this could have false positives, but I think the chances are really low in practice. Depends on #1716.

@SwiftLintBot
Copy link

SwiftLintBot commented Jul 27, 2017

12 Messages
📖 Linting Aerial with this PR took 0.36s vs 0.36s on master (0% slower)
📖 Linting Alamofire with this PR took 2.34s vs 2.52s on master (7% faster)
📖 Linting Firefox with this PR took 10.1s vs 10.47s on master (3% faster)
📖 Linting Kickstarter with this PR took 15.67s vs 14.85s on master (5% slower)
📖 Linting Moya with this PR took 0.71s vs 0.71s on master (0% slower)
📖 Linting Nimble with this PR took 1.44s vs 1.4s on master (2% slower)
📖 Linting Quick with this PR took 0.49s vs 0.46s on master (6% slower)
📖 Linting Realm with this PR took 2.27s vs 2.16s on master (5% slower)
📖 Linting SourceKitten with this PR took 0.83s vs 0.8s on master (3% slower)
📖 Linting Sourcery with this PR took 3.63s vs 3.62s on master (0% slower)
📖 Linting Swift with this PR took 10.73s vs 10.4s on master (3% slower)
📖 Linting WordPress with this PR took 10.72s vs 9.78s on master (9% slower)

Generated by 🚫 Danger

@marcelofabri marcelofabri force-pushed the mf-block-based-kvo-rule branch from a3b7cb9 to 3ff9636 Compare July 27, 2017 14:50
@codecov-io
Copy link

codecov-io commented Jul 27, 2017

Codecov Report

Merging #1717 into master will increase coverage by <.01%.
The diff coverage is 87.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1717      +/-   ##
==========================================
+ Coverage   87.43%   87.43%   +<.01%     
==========================================
  Files         208      209       +1     
  Lines       10291    10323      +32     
==========================================
+ Hits         8998     9026      +28     
- Misses       1293     1297       +4
Impacted Files Coverage Δ
Tests/SwiftLintFrameworkTests/RulesTests.swift 100% <100%> (ø) ⬆️
...e/SwiftLintFramework/Rules/BlockBasedKVORule.swift 85.71% <85.71%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ae9635...a9de74f. Read the comment docs.

@marcelofabri marcelofabri force-pushed the mf-block-based-kvo-rule branch from 3ff9636 to a9de74f Compare July 27, 2017 19:06
@marcelofabri marcelofabri merged commit b1dbc62 into master Jul 29, 2017
@marcelofabri marcelofabri deleted the mf-block-based-kvo-rule branch July 29, 2017 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants