Add unneeded_parentheses_in_closure_argument rule

[marcelofabri]

Fixes #1483

• Should this be a default rule?
• Should it be configurable (see Rule request: Unneeded parentheses in closure argument #1483 (comment))?

[SwiftLintBot]

	374 Warnings
⚠️	This PR introduced a violation in Firefox: /Account/FxAClient10.swift#L236:45: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Firefox: /Client/Extensions/UIImageViewExtensions.swift#L99:78: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Firefox: /Client/Application/AppDelegate.swift#L147:137: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Firefox: /Client/Frontend/Browser/BackForwardListAnimator.swift#L66:34: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Firefox: /Client/Frontend/Browser/BackForwardListAnimator.swift#L77:34: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Firefox: /Client/Frontend/Browser/Authenticator.swift#L121:50: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Firefox: /Client/Frontend/Browser/Authenticator.swift#L131:98: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Firefox: /Client/Frontend/Browser/Authenticator.swift#L137:30: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Firefox: /Client/Frontend/Browser/Authenticator.swift#L143:30: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Firefox: /Client/Frontend/Browser/FaviconManager.swift#L67:50: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Firefox: /Client/Frontend/Browser/FaviconManager.swift#L72:51: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Firefox: /Client/Frontend/Browser/ErrorPageHelper.swift#L135:101: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Firefox: /Client/Frontend/Browser/ErrorPageHelper.swift#L204:103: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Firefox: /Client/Frontend/Browser/ErrorPageHelper.swift#L209:104: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Firefox: /Client/Frontend/Browser/MailProviders.swift#L18:32: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Firefox: /Client/Frontend/Browser/MailProviders.swift#L32:33: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Firefox: /Client/Frontend/Browser/LoginsHelper.swift#L234:77: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Firefox: /Client/Frontend/Browser/OpenWithSettingsViewController.swift#L70:42: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Firefox: /Client/Frontend/Browser/OpenInHelper.swift#L62:117: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Firefox: /Client/Frontend/Browser/OpenInHelper.swift#L99:93: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Firefox: /Client/Frontend/Browser/ReaderModeBarView.swift#L84:48: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Firefox: /Client/Frontend/Browser/ReaderModeBarView.swift#L91:46: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Firefox: /Client/Frontend/Browser/ReaderModeBarView.swift#L97:48: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Firefox: /Client/Frontend/Browser/QRCodeViewController.swift#L144:51: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Firefox: /Client/Frontend/Browser/QRCodeViewController.swift#L149:51: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Firefox: /Client/Frontend/Browser/QRCodeViewController.swift#L214:125: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Firefox: /Client/Frontend/Browser/SearchEngines.swift#L96:49: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Firefox: /Client/Frontend/Browser/SearchViewController.swift#L539:91: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Firefox: /Client/Frontend/Browser/TabManager.swift#L909:84: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Firefox: /Client/Frontend/Browser/TabTrayController.swift#L1052:47: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Firefox: /Client/Frontend/Home/ActivityStreamPanel.swift#L471:141: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Firefox: /Client/Frontend/Home/ActivityStreamPanel.swift#L484:128: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Firefox: /Client/Frontend/Home/BookmarksPanel.swift#L219:93: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Firefox: /Client/Frontend/Home/BookmarksPanel.swift#L370:110: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Firefox: /Client/Frontend/Browser/BrowserViewController.swift#L2834:99: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Firefox: /Client/Frontend/Browser/BrowserViewController.swift#L3286:135: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Firefox: /Client/Frontend/Home/RecentlyClosedTabsPanel.swift#L123:72: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Firefox: /Client/Frontend/Home/HistoryPanel.swift#L361:83: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Firefox: /Client/Frontend/Home/HistoryPanel.swift#L548:110: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Firefox: /Client/Frontend/Intro/IntroViewController.swift#L98:51: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Firefox: /Client/Frontend/Intro/IntroViewController.swift#L122:42: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Firefox: /Client/Frontend/Intro/IntroViewController.swift#L135:43: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Firefox: /Client/Frontend/Intro/IntroViewController.swift#L157:44: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Firefox: /Client/Frontend/Intro/IntroViewController.swift#L170:45: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Firefox: /Client/Frontend/Intro/IntroViewController.swift#L204:44: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Firefox: /Client/Frontend/Intro/IntroViewController.swift#L363:36: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Firefox: /Client/Frontend/Intro/IntroViewController.swift#L375:46: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Firefox: /Client/Frontend/Home/TopSitesPanel.swift#L573:53: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Firefox: /Client/Frontend/Home/TopSitesPanel.swift#L613:75: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Firefox: /Client/Frontend/Reader/ReaderMode.swift#L290:125: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Firefox: /Client/Frontend/Reader/ReaderModeStyleViewController.swift#L69:43: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Firefox: /Client/Frontend/Reader/ReaderModeStyleViewController.swift#L115:40: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Firefox: /Client/Frontend/Reader/ReaderModeStyleViewController.swift#L135:45: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Firefox: /Client/Frontend/Reader/ReaderModeStyleViewController.swift#L155:54: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Firefox: /Client/Frontend/Reader/ReaderModeStyleViewController.swift#L163:54: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Firefox: /Client/Frontend/Settings/ClearPrivateDataTableViewController.swift#L115:28: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Firefox: /Client/Frontend/Settings/CustomSearchViewController.swift#L102:64: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Firefox: /Client/Frontend/Settings/AppSettingsOptions.swift#L65:117: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Firefox: /Client/Frontend/Settings/AppSettingsOptions.swift#L69:99: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Firefox: /Client/Frontend/Share/ShareExtensionHelper.swift#L144:101: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Firefox: /Client/Frontend/Share/ShareExtensionHelper.swift#L160:116: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Firefox: /Client/Frontend/Widgets/PhotonActionSheet.swift#L258:56: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Firefox: /Client/Helpers/FxALoginHelper.swift#L133:85: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Firefox: /Extensions/SendTo/ActionViewController.swift#L31:106: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Firefox: /Extensions/SendTo/InstructionsViewController.swift#L65:34: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Firefox: /Client/Utils/FaviconFetcher.swift#L193:29: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Firefox: /Client/Utils/FaviconFetcher.swift#L198:30: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Firefox: /Client/Utils/FaviconFetcher.swift#L230:135: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Firefox: /Extensions/ShareTo/InitialViewController.swift#L23:106: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Firefox: /Extensions/ShareTo/InitialViewController.swift#L46:26: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Firefox: /Extensions/ShareTo/InitialViewController.swift#L61:26: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Firefox: /Extensions/SendTo/ClientPickerViewController.swift#L240:41: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Firefox: /Extensions/SendTo/ClientPickerViewController.swift#L292:41: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Firefox: /Extensions/ViewLater/ActionRequestHandler.swift#L14:92: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Firefox: /L10nSnapshotTests/L10nBaseSnapshotTests.swift#L35:45: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Firefox: /Providers/SyncStatusResolver.swift#L72:63: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Firefox: /Providers/Profile.swift#L1063:110: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Firefox: /Shared/Functions.swift#L42:14: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Firefox: /Storage/PageMetadata.swift#L74:121: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Firefox: /Storage/MockLogins.swift#L18:25: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Firefox: /Storage/MockLogins.swift#L30:25: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Firefox: /Storage/MockLogins.swift#L47:59: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Firefox: /Storage/MockLogins.swift#L62:25: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Firefox: /Storage/MockLogins.swift#L72:25: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Firefox: /Storage/SQL/DeferredDBOperation.swift#L83:72: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Firefox: /Storage/SQL/BrowserDB.swift#L451:43: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Firefox: /Storage/SQL/SQLiteBookmarksSyncing.swift#L294:72: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Firefox: /Storage/SQL/SQLiteBookmarksSyncing.swift#L429:41: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Firefox: /Storage/SQL/SQLiteBookmarksSyncing.swift#L1059:40: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Firefox: /Sync/RequestExtensions.swift#L34:39: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Firefox: /Sync/RequestExtensions.swift#L49:39: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Firefox: /Sync/Synchronizers/Bookmarks/BookmarksSynchronizer.swift#L42:29: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Firefox: /Sync/Synchronizers/Bookmarks/BookmarksSynchronizer.swift#L343:52: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Firefox: /Sync/Synchronizers/Bookmarks/BookmarksRepairRequestor.swift#L460:60: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Firefox: /Sync/Synchronizers/IndependentRecordSynchronizer.swift#L25:65: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Firefox: /Sync/Synchronizers/ClientsSynchronizer.swift#L247:41: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Firefox: /Sync/Synchronizers/ClientsSynchronizer.swift#L374:20: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Firefox: /Sync/Synchronizers/HistorySynchronizer.swift#L131:90: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Firefox: /Sync/Synchronizers/TabsSynchronizer.swift#L132:47: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Firefox: /Sync/SyncTelemetry.swift#L247:84: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Firefox: /Telemetry/PingCentre.swift#L150:56: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Firefox: /Sync/SyncStateMachine.swift#L126:42: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Firefox: /TestBookmarksRepairRequestor.swift#L419:112: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Kickstarter: /Kickstarter-iOS/ViewModels/UpdateViewModel.swift#L118:20: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Kickstarter: /Library/ViewModels/BackerDashboardProjectsViewModel.swift#L92:14: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Kickstarter: /Library/ViewModels/DashboardViewModel.swift#L208:20: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Kickstarter: /Library/ViewModels/LiveStreamCountdownViewModel.swift#L160:24: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Kickstarter: /Library/ViewModels/LiveStreamContainerViewModel.swift#L451:24: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Kickstarter: /Library/ViewModels/ProjectDescriptionViewModel.swift#L65:14: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Kickstarter: /Library/ViewModels/ProjectDescriptionViewModel.swift#L73:14: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Kickstarter: /Library/ViewModels/ProjectNotificationCellViewModel.swift#L42:14: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Kickstarter: /Library/ViewModels/RewardPledgeViewModel.swift#L240:20: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Kickstarter: /Library/ViewModels/ShareViewModel.swift#L73:14: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Kickstarter: /Library/ViewModels/UpdateDraftViewModel.swift#L217:20: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Kickstarter: /Library/ViewModels/UpdateDraftViewModel.swift#L303:18: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Kickstarter: /LiveStream/Service/LiveStreamService.swift#L55:29: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Kickstarter: /LiveStream/Service/LiveStreamService.swift#L105:29: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Kickstarter: /LiveStream/Service/LiveStreamService.swift#L145:31: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Kickstarter: /LiveStream/Service/LiveStreamService.swift#L189:31: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	This PR introduced a violation in Kickstarter: /LiveStream/Service/LiveStreamService.swift#L238:31: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)
⚠️	Danger found 374 violations with this PR. Due to GitHub's max issue comment size, the number shown has been truncated to 120.

	12 Messages
📖	Linting Aerial with this PR took 0.36s vs 0.33s on master (9% slower)
📖	Linting Alamofire with this PR took 2.44s vs 2.37s on master (2% slower)
📖	Linting Firefox with this PR took 10.59s vs 10.06s on master (5% slower)
📖	Linting Kickstarter with this PR took 14.66s vs 14.49s on master (1% slower)
📖	Linting Moya with this PR took 0.64s vs 0.64s on master (0% slower)
📖	Linting Nimble with this PR took 1.32s vs 1.32s on master (0% slower)
📖	Linting Quick with this PR took 0.44s vs 0.43s on master (2% slower)
📖	Linting Realm with this PR took 2.05s vs 2.12s on master (3% faster)
📖	Linting SourceKitten with this PR took 0.79s vs 0.78s on master (1% slower)
📖	Linting Sourcery with this PR took 2.81s vs 2.84s on master (1% faster)
📖	Linting Swift with this PR took 9.77s vs 10.08s on master (3% faster)
📖	Linting WordPress with this PR took 9.76s vs 9.41s on master (3% slower)

Generated by 🚫 Danger

[codecov-io]

Codecov Report

Merging #1684 into master will increase coverage by 0.03%.
The diff coverage is 96%.

@@            Coverage Diff             @@
##           master    #1684      +/-   ##
==========================================
+ Coverage   87.39%   87.43%   +0.03%     
==========================================
  Files         204      205       +1     
  Lines       10067    10114      +47     
==========================================
+ Hits         8798     8843      +45     
- Misses       1269     1271       +2

Impacted Files	Coverage Δ
Tests/SwiftLintFrameworkTests/RulesTests.swift	100% <100%> (ø)	⬆️
...urce/SwiftLintFramework/Rules/AttributesRule.swift	98.2% <100%> (ø)	⬆️
...SwiftLintFramework/Rules/GenericTypeNameRule.swift	93.54% <100%> (ø)	⬆️
...les/UnneededParenthesesInClosureArgumentRule.swift	95.55% <95.55%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8af2334...57f52b6. Read the comment docs.

[Jeehut]

I'm for making this default. I still don't understand why Xcode is creating those parentheses in the first place ....

[marcelofabri]

Honestly, I think it should be default. But I've done some informal survey with some friends and the majority actually prefer having the parentheses ¯\(ツ)/¯

Also, I've not implemented any configurations as we've discussed, so it'd be harder for people to bend the rule to what they prefer.

[Jeehut]

I know that some like them as they are. Some are still using self. all over the place. I was one of them once, but embracing the clarity of Swift also let me rethink and I'm happy I've done so. The reason for that were the community standards, now I type less and the code is still clear.

That's why I think we should make it default once Xcode doesn't add them by default. I hope that the time will come sometime. Thanks for implementing this anyways! Good work. 👍

[jpsim]

Cool.