Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix configuration issue when using custom paths #1644

Merged
merged 1 commit into from
Jul 1, 2017
Merged

Fix configuration issue when using custom paths #1644

merged 1 commit into from
Jul 1, 2017

Conversation

marcelofabri
Copy link
Collaborator

Fixes #1631

// @vincentisambart could you try this to be sure it fixes the issue?

@marcelofabri marcelofabri requested a review from jpsim June 24, 2017 20:55
@SwiftLintBot
Copy link

12 Messages
📖 Linting Aerial with this PR took 0.36s vs 0.33s on master (9% slower)
📖 Linting Alamofire with this PR took 2.25s vs 2.22s on master (1% slower)
📖 Linting Firefox with this PR took 9.76s vs 9.72s on master (0% slower)
📖 Linting Kickstarter with this PR took 14.02s vs 14.22s on master (1% faster)
📖 Linting Moya with this PR took 0.64s vs 0.65s on master (1% faster)
📖 Linting Nimble with this PR took 1.3s vs 1.3s on master (0% slower)
📖 Linting Quick with this PR took 0.42s vs 0.42s on master (0% slower)
📖 Linting Realm with this PR took 1.96s vs 1.97s on master (0% faster)
📖 Linting SourceKitten with this PR took 0.84s vs 0.84s on master (0% slower)
📖 Linting Sourcery with this PR took 2.68s vs 2.71s on master (1% faster)
📖 Linting Swift with this PR took 9.01s vs 8.89s on master (1% slower)
📖 Linting WordPress with this PR took 9.39s vs 9.43s on master (0% faster)

Generated by 🚫 Danger

@codecov-io
Copy link

Codecov Report

Merging #1644 into master will decrease coverage by <.01%.
The diff coverage is 60%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1644      +/-   ##
==========================================
- Coverage   88.08%   88.08%   -0.01%     
==========================================
  Files         196      196              
  Lines        9838     9850      +12     
==========================================
+ Hits         8666     8676      +10     
- Misses       1172     1174       +2
Impacted Files Coverage Δ
...iftlint/Extensions/Configuration+CommandLine.swift 0% <0%> (ø) ⬆️
Source/swiftlint/Commands/RulesCommand.swift 0% <0%> (ø) ⬆️
...urce/SwiftLintFramework/Models/Configuration.swift 86.97% <100%> (+1.74%) ⬆️
...s/SwiftLintFrameworkTests/ConfigurationTests.swift 94.38% <100%> (+0.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c02020...68c1f3c. Read the comment docs.

@vincentisambart
Copy link

@marcelofabri I just tried on my machine and it does seem to fix the problem for me, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When --path is used, the directory's .swiftlint.yml is ignored
4 participants