Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty_parameters rule with Swift 3 #1474

Merged
merged 1 commit into from
Apr 30, 2017
Merged

Fix empty_parameters rule with Swift 3 #1474

merged 1 commit into from
Apr 30, 2017

Conversation

marcelofabri
Copy link
Collaborator

Fixes #1460

@SwiftLintBot
Copy link

20 Warnings
⚠️ This PR introduced a violation in WordPress: /WordPress/WordPressShareExtension/ShareViewController.swift#L257:146: warning: Empty Parameters Violation: Prefer () -> over Void -> . (empty_parameters)
⚠️ This PR introduced a violation in Alamofire: /Tests/RequestTests.swift#L393:56: warning: Empty Parameters Violation: Prefer () -> over Void -> . (empty_parameters)
⚠️ This PR introduced a violation in Firefox: /Providers/Profile.swift#L774:70: warning: Empty Parameters Violation: Prefer () -> over Void -> . (empty_parameters)
⚠️ This PR introduced a violation in Realm: /RealmSwift/Tests/ObjectAccessorTests.swift#L98:29: warning: Empty Parameters Violation: Prefer () -> over Void -> . (empty_parameters)
⚠️ This PR introduced a violation in WordPress: /WordPress/Classes/Networking/PeopleServiceRemote.swift#L190:31: warning: Empty Parameters Violation: Prefer () -> over Void -> . (empty_parameters)
⚠️ This PR introduced a violation in WordPress: /WordPress/Classes/Networking/PeopleServiceRemote.swift#L218:35: warning: Empty Parameters Violation: Prefer () -> over Void -> . (empty_parameters)
⚠️ This PR introduced a violation in WordPress: /WordPress/Classes/Networking/PeopleServiceRemote.swift#L241:33: warning: Empty Parameters Violation: Prefer () -> over Void -> . (empty_parameters)
⚠️ This PR introduced a violation in WordPress: /WordPress/Classes/Networking/PeopleServiceRemote.swift#L295:49: warning: Empty Parameters Violation: Prefer () -> over Void -> . (empty_parameters)
⚠️ This PR introduced a violation in WordPress: /WordPress/Classes/Networking/PeopleServiceRemote.swift#L338:45: warning: Empty Parameters Violation: Prefer () -> over Void -> . (empty_parameters)
⚠️ This PR introduced a violation in WordPress: /WordPress/Classes/Services/NotificationSyncMediator.swift#L299:80: warning: Empty Parameters Violation: Prefer () -> over Void -> . (empty_parameters)
⚠️ This PR introduced a violation in Alamofire: /Tests/RequestTests.swift#L385:55: warning: Empty Parameters Violation: Prefer () -> over Void -> . (empty_parameters)
⚠️ This PR introduced a violation in WordPress: /WordPress/Classes/Services/PeopleService.swift#L238:49: warning: Empty Parameters Violation: Prefer () -> over Void -> . (empty_parameters)
⚠️ This PR introduced a violation in WordPress: /WordPress/Classes/Services/PeopleService.swift#L260:45: warning: Empty Parameters Violation: Prefer () -> over Void -> . (empty_parameters)
⚠️ This PR introduced a violation in WordPress: /WordPress/Classes/ViewRelated/Me/AboutViewController.swift#L170:23: warning: Empty Parameters Violation: Prefer () -> over Void -> . (empty_parameters)
⚠️ This PR introduced a violation in WordPress: /WordPress/Classes/ViewRelated/Me/AboutViewController.swift#L172:57: warning: Empty Parameters Violation: Prefer () -> over Void -> . (empty_parameters)
⚠️ This PR introduced a violation in WordPress: /WordPress/Classes/ViewRelated/Notifications/Tools/NotificationMediaDownloader.swift#L222:40: warning: Empty Parameters Violation: Prefer () -> over Void -> . (empty_parameters)
⚠️ This PR introduced a violation in WordPress: /WordPress/Classes/ViewRelated/NUX/EpilogueSegue.swift#L8:48: warning: Empty Parameters Violation: Prefer () -> over Void -> . (empty_parameters)
⚠️ This PR introduced a violation in WordPress: /WordPress/Classes/ViewRelated/People/InvitePersonViewController.swift#L251:48: warning: Empty Parameters Violation: Prefer () -> over Void -> . (empty_parameters)
⚠️ This PR introduced a violation in WordPress: /WordPress/Classes/ViewRelated/Post/AztecPostViewController.swift#L1934:139: warning: Empty Parameters Violation: Prefer () -> over Void -> . (empty_parameters)
⚠️ This PR introduced a violation in WordPress: /WordPress/Classes/Services/NotificationSyncMediator.swift#L325:98: warning: Empty Parameters Violation: Prefer () -> over Void -> . (empty_parameters)
12 Messages
📖 Linting WordPress with this PR took 12.34s vs 12.38s on master (0% faster)
📖 Linting Alamofire with this PR took 3.06s vs 3.07s on master (0% faster)
📖 Linting Firefox with this PR took 13.29s vs 13.26s on master (0% slower)
📖 Linting Kickstarter with this PR took 17.6s vs 17.72s on master (0% faster)
📖 Linting Moya with this PR took 0.4s vs 0.4s on master (0% slower)
📖 Linting Nimble with this PR took 1.74s vs 1.74s on master (0% slower)
📖 Linting Aerial with this PR took 0.42s vs 0.41s on master (2% slower)
📖 Linting Realm with this PR took 2.7s vs 2.77s on master (2% faster)
📖 Linting SourceKitten with this PR took 1.12s vs 1.12s on master (0% slower)
📖 Linting Sourcery with this PR took 2.96s vs 2.95s on master (0% slower)
📖 Linting Swift with this PR took 12.64s vs 12.55s on master (0% slower)
📖 Linting Quick with this PR took 0.51s vs 0.51s on master (0% slower)

Generated by 🚫 danger

@codecov-io
Copy link

Codecov Report

Merging #1474 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1474   +/-   ##
======================================
  Coverage      83%     83%           
======================================
  Files         178     178           
  Lines        8977    8977           
======================================
  Hits         7451    7451           
  Misses       1526    1526
Impacted Files Coverage Δ
...SwiftLintFramework/Rules/EmptyParametersRule.swift 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5673b3f...42e6c8a. Read the comment docs.

@jpsim jpsim merged commit efdc31d into realm:master Apr 30, 2017
@jpsim
Copy link
Collaborator

jpsim commented Apr 30, 2017

🎉

@marcelofabri marcelofabri deleted the bugfix-1460 branch April 30, 2017 16:58
@Jerrot
Copy link

Jerrot commented May 2, 2017

Thank you! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants