Sorted imports #1071
Merged
Sorted imports #1071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpsim
approved these changes
Dec 26, 2016
| @@ -38,6 +38,10 @@ | |||
| [Marcelo Fabri](https://github.com/marcelofabri) | |||
| [#1066](https://github.com/realm/SwiftLint/issues/1066) | |||
|
|
|||
| * Add a rule that enforces alphabetical sorting of imports. | |||
Current coverage is 83.29% (diff: 96.15%)@@ master #1071 diff @@
==========================================
Files 147 148 +1
Lines 7189 7215 +26
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 5985 6010 +25
- Misses 1204 1205 +1
Partials 0 0
|
This was referenced Dec 26, 2016
|
I squashed all commits because I thought that was @sberrevoets's idea, but it seems it removed his name from the history. I'm sorry 😰 |
|
It's ok. His name will forever be credited in the changelog. The only place that matters :) |
|
Believe it or not, I was actually able to not open my laptop for a few days so didn't get a chance to look finish this up. Thanks for taking this over the finish line @marcelofabri! |
|
I applaud your self-restraint |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continued from #991