syntactic_sugar rule now doesn't flag declarations that can't be fixed

[marcelofabri]

Fixes #928

[codecov-io]

Current coverage is 82.90% (diff: 91.66%)

Merging #1041 into master will increase coverage by 0.01%

@@             master      #1041   diff @@
==========================================
  Files           144        144          
  Lines          6996       7014    +18   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits           5799       5815    +16   
- Misses         1197       1199     +2   
  Partials          0          0          

Powered by Codecov. Last update 49eabb7...9253977

[jpsim]

more of a bug fix, wouldn't you say?

[marcelofabri]

yeah, I think so. I'll update it.

[jpsim]

You could probably also fix the false positives reported from using Optional<T>.self, such as

unsafeBitCast(nonOptionalT, to: Optional<T>.self)

There are quite a few of these false positives in Realm: https://github.com/realm/realm-cocoa/blob/v2.1.2/RealmSwift/LinkingObjects.swift#L160

[jpsim]

"avoids trigering" -> "avoid triggering"

[marcelofabri]

You could probably also fix the false positives reported from using Optional<T>.self

I've handled them in 0bd1647, but I don't know if .self is the only case that should be handled.

[jpsim]

There's one more false positive type in Realm: https://github.com/realm/realm-cocoa/blob/v2.1.2/RealmSwift/Object.swift#L331

if type is Optional<String>.Type

Can be fixed with:

-                if file.matchPattern("\\s*\\.self", withSyntaxKinds: [.keyword],
-                                     range: restOfFileRange).first?.location == start {
+                if let match = file.matchPattern("\\s*\\.(?:self|Type)", range: restOfFileRange).first,
+                    match.0.location == start, match.1 == [.keyword] || match.1 == [.identifier] {
                     return nil

[jpsim]

🎉