Fix false positive in operator_usage_whitespace
#1030
Conversation
Current coverage is 82.68% (diff: 100%)@@ master #1030 diff @@
==========================================
Files 140 140
Lines 6832 6832
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 5649 5649
Misses 1183 1183
Partials 0 0
|
| @@ -105,7 +107,7 @@ public struct OperatorUsageWhitespaceRule: OptInRule, CorrectableRule, Configura | |||
| zeroSpaces + trailingVariableOrNumber | |||
| let excludingPattern = "(?:\(genericPattern)|\(validRangePattern))" | |||
|
|
|||
| let kinds = SyntaxKind.commentAndStringKinds() | |||
| let kinds = SyntaxKind.commentAndStringKinds() + [.objectLiteral] | |||
There was a problem hiding this comment.
I would suspect that other rules that exclude comments and strings would also need to exclude object literals.
This is why checking for explicit matching kinds is always preferable to excluding.
There was a problem hiding this comment.
I agree, but I'm not sure what we should do. Maybe rename commentAndStringKinds and make it return .objectLiteral as well?
There was a problem hiding this comment.
yes, basically "non-code kinds", and check to see if there are even more kinds that fall into that category.
There was a problem hiding this comment.
I've looked at all the other rules using commentAndStringKinds() and I don't think any of them would benefit from also including image literals. So let's keep it just here for now.
Fixes #1028