Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression in CommaRule from 0.9.1 introduced in 0.9.2 #683

Closed
andymatuschak opened this issue Jun 7, 2016 · 4 comments
Closed

Regression in CommaRule from 0.9.1 introduced in 0.9.2 #683

andymatuschak opened this issue Jun 7, 2016 · 4 comments
Labels
bug Unexpected and reproducible misbehavior.

Comments

@andymatuschak
Copy link

andymatuschak commented Jun 7, 2016

Hello! With swiftlint 0.9.1, the following source listing correctly produces a CommaRule violation. As of swiftlint 0.9.2, it no longer produces the violation.

func plus(first: Int, second: Int) -> Int {
    return first + second
}

let result = plus(
    first: 3 , // <--- this should produce an error
    second: 4
)

cc @norio-nomura

@jpsim jpsim added the bug Unexpected and reproducible misbehavior. label Jun 7, 2016
@jpsim
Copy link
Collaborator

jpsim commented Jun 7, 2016

good to know! thanks for reporting.

@andymatuschak
Copy link
Author

The regression was introduced in 6f17c93.

@norio-nomura
Copy link
Collaborator

Thanks for reporting! 🙏
I pushed fix #685

@jpsim jpsim closed this as completed in #685 Jun 8, 2016
@andymatuschak
Copy link
Author

Woo! Thanks. :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Unexpected and reproducible misbehavior.
Projects
None yet
Development

No branches or pull requests

3 participants