Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Line Length rule configurable #598

Closed
jpsim opened this issue Mar 29, 2016 · 4 comments
Closed

Make Line Length rule configurable #598

jpsim opened this issue Mar 29, 2016 · 4 comments
Labels
rule-request Requests for a new rules.

Comments

@jpsim
Copy link
Collaborator

jpsim commented Mar 29, 2016

To allow ignoring comment-only lines. As requested in #597.
@jpsim jpsim added the rule-request Requests for a new rules. label Mar 29, 2016
@jpsim jpsim mentioned this issue Mar 29, 2016
Closed
@gsabran
Copy link

gsabran commented Jul 9, 2016

Any update on this? That'd be very helpful, especially since default files have long comments that break the rule

@jpsim
Copy link
Collaborator Author

jpsim commented Jul 12, 2016

@gsabran to my knowledge, no one's started on this. This is a great starter task, would you be interested in giving it a shot?

@marcelofabri marcelofabri mentioned this issue Dec 14, 2016
Closed
@mlwelles
Copy link
Contributor

I took a pass fixing this and #975, and just submitted a pull request: #1264

marcelofabri added a commit that referenced this issue Feb 6, 2017
@marcelofabri
Merge pull request #1264 from mlwelles/line-length-rule-configurable
56bbf12 
Changes for issue #598 to make line length rule configurable
@marcelofabri
Copy link
Collaborator

Fixed by @mlwelles in #1264! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
rule-request Requests for a new rules.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jpsim @mlwelles @marcelofabri @gsabran