Add ControlStatementRule #39
Conversation
| return StyleViolation(type: .ControlStatement, | ||
| location: Location(file: file, offset: range.location), | ||
| severity: .Low, | ||
| reason: "if,for,while,do statements shouldn't wrap their conditionals in parentheses.") |
There was a problem hiding this comment.
should probably use the regex match for the specific keyword instead of listing them all
|
This is really great, @andreamazz! Thanks for the PR ✨ You'll have to resolve the merge conflict before we can merge this. Also, |
| withSyntaxKinds: [.Keyword]).map{ return ($0, "for") } | ||
| let whileStatement = file.matchPattern("\\s{0,}(while)\\s{0,}\\(", | ||
| withSyntaxKinds: [.Keyword]).map{ return ($0, "while") } | ||
| return (ifStatement + forStatement + whileStatement).map { violation in |
There was a problem hiding this comment.
Should we separate while from do-while statements?
|
Fixed the conflict 👍 |
|
Looks great, @andreamazz! Could you add an entry to CHANGELOG.md under "Enhancements"? |
|
Sure! Updated. |
|
Fantastic, thanks for the hard work @andreamazz! |
|
FYI, there were a few false positives with this rule, especially when using tuples in control statements, and I've attempted to address those in #48. |
|
Right, tuples did not cross my mind 😅 |
Hi @jpsim
I've added the lint rule for
if,for,whileanddowhile statements as mentioned in one of the Todos in the test suite.